28487[TASK] Move update functionality to BackendUserSessionRepository
Commit message
Review
-
Code review CR +2
- Stefan Neufeind +2
- Pascal Dürsteler +1
- Wouter Wolters +1
- Philipp Gampe +1
-
Verified V +2
- Stefan Neufeind +2
- Pascal Dürsteler +1
- Philipp Gampe +1
Issues 1
Files 2
Review log 30
Show 5 earlier messages
-
Pascal Dürsteler uploaded patch set 2 03/18/14, 08:57
-
Mr. Jenkins commented on patch set 1 03/18/14, 09:05
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15242/ : SUCCESS -
Mr. Jenkins commented on patch set 2 03/18/14, 09:11
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15243/ : SUCCESS -
Pascal Dürsteler voted on patch set 2 V +1 03/18/14, 13:11
-
Stefan Neufeind commented on patch set 2 03/18/14, 13:28
SwitchBackUserHook.php:55\TYPO3\CMS\Core\Utility\GeneralUtility::makeInstance('TYPO3\\CMS\\Extbase\\Object\\ObjectManager')SwitchBackUserHook.php:56$objectManager->get(...) here then?
-
Pascal Dürsteler uploaded patch set 3 03/18/14, 13:45
-
Pascal Dürsteler uploaded patch set 4 03/18/14, 13:54
-
Mr. Jenkins commented on patch set 3 03/18/14, 13:59
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15271/ : SUCCESS -
Mr. Jenkins commented on patch set 4 03/18/14, 14:08
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15272/ : SUCCESS -
Oliver Klee commented on patch set 4 03/18/14, 16:29
BackendUserSessionRepository.php:64If I understand this correctly: Actually, the method name and the comment are misleading. This method does not particularly switch back to the original user - it switches to the user whose data is provided as the parameter.BackendUserSessionRepository.php:69No abbreviations, please: $auth -> $authentication (or $userAuthentication)BackendUserSessionRepository.php:72Please also add the comma after the last array element.SwitchBackUserHook.php:45What about moving this condition to a well-name method so we don't need the comment anymore?SwitchBackUserHook.php:55Please generally use two slashes for slashes in strings. The leading slash for the class name is not needed for makeInstance.SwitchBackUserHook.php:56Ditto. -
Stefan Neufeind commented on patch set 4 03/18/14, 16:32
SwitchBackUserHook.php:55Replyyes of course - and the others inside the string should be doubled. So actually like this: $objectManager = \TYPO3\CMS\Core\Utility\GeneralUtility::makeInstance('TYPO3\\CMS\\Extbase\\Object\\ObjectManager');SwitchBackUserHook.php:56Replydito for doubleslashes also here -
Pascal Dürsteler uploaded patch set 5 03/19/14, 09:20
-
Mr. Jenkins commented on patch set 5 CR -1 V -1 03/19/14, 09:34
Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/15315/ : FAILURE -
Pascal Dürsteler uploaded patch set 6 03/19/14, 09:36
-
Pascal Dürsteler voted on patch set 6 V +1 03/19/14, 09:44
-
Mr. Jenkins commented on patch set 6 03/19/14, 09:53
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15318/ : SUCCESS -
Pascal Dürsteler commented on patch set 6 CR +1 03/20/14, 08:21
This precedes http://forge.typo3.org/issues/22020, which is ready after this one has been merged. -
Helmut Hummel commented on patch set 6 03/22/14, 13:52
Thanks. Nice change!BackendUserSessionRepository.php:57Why did you change this? -
Wouter Wolters commented on patch set 6 03/22/14, 14:05
BackendUserSessionRepository.php:57ReplyThis is already changed in https://review.typo3.org/#/c/28462/2 to respect timezone -
Christian Kuhn updated the commit message in patch set 6 03/22/14, 16:46
-
Christian Kuhn commented on patch set 7 03/22/14, 16:47
imho 6.2 only. -
Mr. Jenkins commented on patch set 7 03/22/14, 17:00
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15526/ : SUCCESS -
Wouter Wolters rebased onto patch set 7 03/23/14, 13:21
-
Wouter Wolters voted on patch set 8 CR +1 03/23/14, 13:22
-
Stefan Neufeind voted on patch set 8 CR +1 03/23/14, 13:26
-
Mr. Jenkins commented on patch set 8 03/23/14, 13:35
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15559/ : SUCCESS -
Philipp Gampe commented on patch set 8 V +1 CR +1 03/23/14, 17:23
works fine for me (switch-to and switch-back) -
Pascal Dürsteler voted on patch set 8 V +1 CR +1 03/23/14, 17:27
-
Stefan Neufeind voted on patch set 8 V +2 CR +2 03/23/14, 18:01
-
Stefan Neufeind merged patch set 9 03/23/14, 18:01