Review main Merged

28487[TASK] Move update functionality to BackendUserSessionRepository

Pascal Dürsteler CR +2 V +2 Normal +57 −29 updated 03/23/14, 18:01

Commit message

As annotated in SwitchBackUserHook.php, the update method is moved
into the BackendUserSessionRepository file.

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Pascal Dürsteler +1
    • Wouter Wolters +1
    • Philipp Gampe +1
  • Verified V +2
    • Stefan Neufeind +2
    • Pascal Dürsteler +1
    • Philipp Gampe +1

Issues 1

Files 2

Review log 30

Show 5 earlier messages
  1. Pascal Dürsteler uploaded patch set 2 03/18/14, 08:57

  2. Mr. Jenkins commented on patch set 1 03/18/14, 09:05

  3. Mr. Jenkins commented on patch set 2 03/18/14, 09:11

  4. Pascal Dürsteler voted on patch set 2 V +1 03/18/14, 13:11

  5. Stefan Neufeind commented on patch set 2 03/18/14, 13:28

    SwitchBackUserHook.php:55

    \TYPO3\CMS\Core\Utility\GeneralUtility::makeInstance('TYPO3\\CMS\\Extbase\\Object\\ObjectManager')

    SwitchBackUserHook.php:56

    $objectManager->get(...) here then?
  1. Pascal Dürsteler uploaded patch set 3 03/18/14, 13:45

  2. Pascal Dürsteler uploaded patch set 4 03/18/14, 13:54

  3. Mr. Jenkins commented on patch set 3 03/18/14, 13:59

  4. Mr. Jenkins commented on patch set 4 03/18/14, 14:08

  5. Oliver Klee commented on patch set 4 03/18/14, 16:29

    BackendUserSessionRepository.php:64

    If I understand this correctly: Actually, the method name and the comment are misleading. This method does not particularly switch back to the original user - it switches to the user whose data is provided as the parameter.

    BackendUserSessionRepository.php:69

    No abbreviations, please: $auth -> $authentication (or $userAuthentication)

    BackendUserSessionRepository.php:72

    Please also add the comma after the last array element.

    SwitchBackUserHook.php:45

    What about moving this condition to a well-name method so we don't need the comment anymore?

    SwitchBackUserHook.php:55

    Please generally use two slashes for slashes in strings. The leading slash for the class name is not needed for makeInstance.

    SwitchBackUserHook.php:56

    Ditto.
  6. Stefan Neufeind commented on patch set 4 03/18/14, 16:32

    SwitchBackUserHook.php:55 Reply

    yes of course - and the others inside the string should be doubled. So actually like this: $objectManager = \TYPO3\CMS\Core\Utility\GeneralUtility::makeInstance('TYPO3\\CMS\\Extbase\\Object\\ObjectManager');

    SwitchBackUserHook.php:56 Reply

    dito for doubleslashes also here
  7. Pascal Dürsteler uploaded patch set 5 03/19/14, 09:20

  8. Mr. Jenkins commented on patch set 5 CR -1 V -1 03/19/14, 09:34

  9. Pascal Dürsteler uploaded patch set 6 03/19/14, 09:36

  10. Pascal Dürsteler voted on patch set 6 V +1 03/19/14, 09:44

  11. Mr. Jenkins commented on patch set 6 03/19/14, 09:53

  12. Pascal Dürsteler commented on patch set 6 CR +1 03/20/14, 08:21

    This precedes http://forge.typo3.org/issues/22020, which is ready after this one has been merged.
  13. Helmut Hummel commented on patch set 6 03/22/14, 13:52

    Thanks. Nice change!

    BackendUserSessionRepository.php:57

    Why did you change this?
  14. Wouter Wolters commented on patch set 6 03/22/14, 14:05

    BackendUserSessionRepository.php:57 Reply

    This is already changed in https://review.typo3.org/#/c/28462/2 to respect timezone
  15. Christian Kuhn updated the commit message in patch set 6 03/22/14, 16:46

  16. Christian Kuhn commented on patch set 7 03/22/14, 16:47

    imho 6.2 only.
  17. Mr. Jenkins commented on patch set 7 03/22/14, 17:00

  18. Wouter Wolters rebased onto patch set 7 03/23/14, 13:21

  19. Wouter Wolters voted on patch set 8 CR +1 03/23/14, 13:22

  20. Stefan Neufeind voted on patch set 8 CR +1 03/23/14, 13:26

  21. Mr. Jenkins commented on patch set 8 03/23/14, 13:35

  22. Philipp Gampe commented on patch set 8 V +1 CR +1 03/23/14, 17:23

    works fine for me (switch-to and switch-back)
  23. Pascal Dürsteler voted on patch set 8 V +1 CR +1 03/23/14, 17:27

  24. Stefan Neufeind voted on patch set 8 V +2 CR +2 03/23/14, 18:01

  25. Stefan Neufeind merged patch set 9 03/23/14, 18:01