Review main Merged

28510[BUGFIX] Support for static table titles in new record wizard

Nicole Hummel CR +2 V +2 Easy +3 −4 updated 03/21/14, 21:55

Commit message

With a static table name the extension key is not updated which sets a
wrong table title for the extension before. This patch resolves table
title from configuration with a fallback to table name part and sets
group name and extension key. This helps to prevent any conflict between
different extensions.

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Wouter Wolters +1
    • Vladimir Podkovanov +1
  • Verified V +2
    • Stefan Neufeind +2

Issues 1

Files 1

Review log 12

  1. Mr. Jenkins commented on patch set 1 03/18/14, 20:19

  2. Nicole Hummel uploaded patch set 2 03/18/14, 20:23

  3. Nicole Hummel commented on patch set 2 03/18/14, 20:26

    It is better to set $_EXTKEY to the extracted extension key from table name to have advanced grouping.
  4. Mr. Jenkins commented on patch set 2 03/18/14, 20:37

  5. Vladimir Podkovanov commented on patch set 2 03/18/14, 20:51

    On Patch Set 2, shouldn't be same change in previous else-branch too? Please see original patch in the bug tracker. If there are several tables with label starting with 'LLL:EXT:' but with empty ext key, it seems that these tables would be messed up too, because of same key (empty string) in $this->tRows.
  6. Nicole Hummel uploaded patch set 3 03/19/14, 08:47

  7. Nicole Hummel commented on patch set 3 03/19/14, 08:49

    @Vladimir: it is necessary to set the $_EXTKEY as this is converted to the group title. So your solution would work for one table with missing name but not for multiple.
  8. Mr. Jenkins commented on patch set 3 03/19/14, 09:03

  9. Vladimir Podkovanov commented on patch set 3 CR +1 03/19/14, 10:18

    @Nicole I meant that previous else branch had to be handled too, not only last one. Now it looks ok for me.
  10. Wouter Wolters voted on patch set 3 CR +1 03/19/14, 18:51

  11. Stefan Neufeind commented on patch set 3 V +2 CR +2 03/21/14, 21:55

    tested, with help from Nicole
  12. Stefan Neufeind merged patch set 4 03/21/14, 21:55