28510[BUGFIX] Support for static table titles in new record wizard
Commit message
Review
-
Code review CR +2
- Stefan Neufeind +2
- Wouter Wolters +1
- Vladimir Podkovanov +1
-
Verified V +2
- Stefan Neufeind +2
Issues 1
Files 1
Review log 12
-
Mr. Jenkins commented on patch set 1 03/18/14, 20:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15286/ : SUCCESS -
Nicole Hummel uploaded patch set 2 03/18/14, 20:23
-
Nicole Hummel commented on patch set 2 03/18/14, 20:26
It is better to set $_EXTKEY to the extracted extension key from table name to have advanced grouping. -
Mr. Jenkins commented on patch set 2 03/18/14, 20:37
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15288/ : SUCCESS -
Vladimir Podkovanov commented on patch set 2 03/18/14, 20:51
On Patch Set 2, shouldn't be same change in previous else-branch too? Please see original patch in the bug tracker. If there are several tables with label starting with 'LLL:EXT:' but with empty ext key, it seems that these tables would be messed up too, because of same key (empty string) in $this->tRows. -
Nicole Hummel uploaded patch set 3 03/19/14, 08:47
-
Nicole Hummel commented on patch set 3 03/19/14, 08:49
@Vladimir: it is necessary to set the $_EXTKEY as this is converted to the group title. So your solution would work for one table with missing name but not for multiple. -
Mr. Jenkins commented on patch set 3 03/19/14, 09:03
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15312/ : SUCCESS -
Vladimir Podkovanov commented on patch set 3 CR +1 03/19/14, 10:18
@Nicole I meant that previous else branch had to be handled too, not only last one. Now it looks ok for me. -
Wouter Wolters voted on patch set 3 CR +1 03/19/14, 18:51
-
Stefan Neufeind commented on patch set 3 V +2 CR +2 03/21/14, 21:55
tested, with help from Nicole -
Stefan Neufeind merged patch set 4 03/21/14, 21:55