Review main Abandoned

28514[TASK] Simplify complexity of core updater

Markus Klein CR 0 V 0 Hard +314 −537 updated 03/21/14, 02:16

Commit message

The class structure of the core updater is rather bloated.
The single classes only contain 5 lines of actual code.
This patch combines all classes into one single class and
also saves one layer of inheritance.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 12

Review log 12

  1. Mr. Jenkins commented on patch set 1 03/19/14, 00:19

  2. Markus Klein voted on patch set 1 V -1 03/19/14, 00:19

  3. Markus Klein uploaded patch set 2 03/19/14, 00:58

  4. Mr. Jenkins commented on patch set 2 03/19/14, 01:13

  5. Christian Kuhn commented on patch set 2 03/19/14, 07:40

    CoreUpdate.php:93

    possible security issue? please sanitize this better, currently this could can call every method of the class that is given by _get, it should be restricted to the ones that are explicitly allowed.
  6. Markus Klein uploaded patch set 3 03/19/14, 15:57

  7. Mr. Jenkins commented on patch set 3 03/19/14, 16:10

  8. Wouter Wolters voted on patch set 3 CR +1 03/19/14, 18:38

  9. Christian Kuhn commented on patch set 3 03/20/14, 20:50

    yeah, well ... this somehow makes the new class a sub-dispatcher ... i'm not really sure if i'm happy with that. what do others say here?
  10. Helmut Hummel commented on patch set 3 CR -2 03/20/14, 20:58

    Sorry I really do not see any benefit in changing this. The architecture of the new install tool is that every action is one class (in contrast to Flow or Extbase where a controller combines many actions). While this might look like an overhead, this architecture has several benefits when it comes to different needs (dependencies) for different actions. While this is not completely true (different dependencies) in this very case, it still is inconsistent regarding all other actions in the install tool. Besides that, small classes with few responsibilities is something to strive for, not a "waste of disc space"
  11. Christian Kuhn commented on patch set 3 CR -1 03/20/14, 21:01

    have the same gut feeling as helmut, imho we should abandon this approach.
  12. Markus Klein abandoned the change 03/21/14, 02:16

    Just made that patch as Christian and I were talking about it a bit. So not a big deal. @Helmut: In general many small files are a very large waste of disk space. Current master (without .git) has 57 MB but occupies 84 MB on disk!! (HDD with NTFS) That's 50% wasted.