Review main Merged

28519[TASK] Follow-up: Cleanup ext_localconf.php of sysexts

Marc Bastian Heinrichs CR +2 V +2 Easy +11 −15 updated 03/19/14, 09:49

Commit message

The Extbase implementation registrations don't have to
be initialized in BE mode only.

Review

  • Code review CR +2
    • Marc Bastian Heinrichs +2
    • Markus Kasten +1
    • Wouter Wolters +1
    • Stefan Froemken +1
    • Xavier Perseguers +1
    • Ernesto Baschny +1
  • Verified V +2
    • Marc Bastian Heinrichs +2
    • Stefan Froemken +1
    • Xavier Perseguers +1

Issues 1

Files 1

Review log 19

  1. Marc Bastian Heinrichs updated the commit message in patch set 1 03/19/14, 09:00

  2. Mr. Jenkins commented on patch set 1 03/19/14, 09:10

  3. Markus Kasten voted on patch set 2 V +1 CR +1 03/19/14, 09:14

  4. Marc Bastian Heinrichs commented on patch set 2 CR -2 03/19/14, 09:15

    ext_localconf.php:23

    change comment also
  5. Mr. Jenkins commented on patch set 2 03/19/14, 09:17

  6. Marc Bastian Heinrichs uploaded patch set 3 03/19/14, 09:22

  7. Marc Bastian Heinrichs commented on patch set 3 CR 0 03/19/14, 09:22

    adapted the comment
  8. Marc Bastian Heinrichs updated the commit message in patch set 3 03/19/14, 09:24

  9. Wouter Wolters commented on patch set 3 CR +1 03/19/14, 09:25

    Thanks Maba! I read the comment above and it was mentioned only for BE. So back when I did the final merge this look ok to me.
  10. Wouter Wolters voted on patch set 4 CR +1 03/19/14, 09:25

  11. Ernesto Baschny voted on patch set 4 CR +1 03/19/14, 09:25

  12. Markus Kasten voted on patch set 4 CR +1 03/19/14, 09:26

  13. Stefan Froemken voted on patch set 4 V +1 CR +1 03/19/14, 09:26

  14. Xavier Perseguers voted on patch set 4 V +1 CR +1 03/19/14, 09:27

  15. Marc Bastian Heinrichs commented on patch set 4 03/19/14, 09:33

    Wouter, jep, it's not BE only since this change https://review.typo3.org/#/c/19967/
  16. Marc Bastian Heinrichs voted on patch set 4 V +2 CR +2 03/19/14, 09:33

  17. Marc Bastian Heinrichs merged patch set 5 03/19/14, 09:33

  18. Mr. Jenkins commented on patch set 3 03/19/14, 09:37

  19. Mr. Jenkins commented on patch set 4 03/19/14, 09:49