Review main Merged

28520[FEATURE] Add complete opcode cache reset

Alexander Opitz CR +2 V +2 Normal +54 −7 updated 03/24/14, 15:33

Commit message

This adds the possibility to reset the complete opcode cache in the
install tool. This functionality may be needed if you update extensions
not via EM and the cache does not stat the files.

Review

  • Code review CR +2
    • Markus Klein +2
    • Stefan Neufeind +1
    • Xavier Perseguers +1
    • Ernesto Baschny +1
  • Verified V +2
    • Markus Klein +2
    • Xavier Perseguers +1
    • Ernesto Baschny +1

Issues 1

Files 4

Review log 20

  1. Mr. Jenkins commented on patch set 1 03/19/14, 10:40

  2. Stefan Neufeind commented on patch set 1 CR +1 03/19/14, 10:40

    makes sense to have something like this - just in case something goes wrong
  3. Markus Klein updated the commit message in patch set 1 03/19/14, 10:52

  4. Markus Klein commented on patch set 2 CR -1 03/19/14, 10:55

    Where is the partial??

    OpcodeCacheUtility.php:110

    does that work with NULL?
  5. Mr. Jenkins commented on patch set 2 03/19/14, 11:05

  6. Alexander Opitz uploaded patch set 3 03/19/14, 11:26

  7. Alexander Opitz commented on patch set 3 03/19/14, 11:27

    Added missing file and missing functionality for wincache
  8. Alexander Opitz commented on patch set 2 03/19/14, 11:27

    OpcodeCacheUtility.php:110 Reply

    Done
  9. Mr. Jenkins commented on patch set 3 03/19/14, 11:40

  10. Georg Ringer updated the commit message in patch set 3 03/19/14, 12:42

  11. Mr. Jenkins commented on patch set 4 03/19/14, 12:57

  12. Markus Klein updated the commit message in patch set 4 03/19/14, 17:23

  13. Markus Klein voted on patch set 5 CR +1 03/19/14, 17:25

  14. Mr. Jenkins commented on patch set 5 03/19/14, 17:44

  15. Stefan Neufeind voted on patch set 5 CR +1 03/20/14, 01:35

  16. Ernesto Baschny commented on patch set 5 V +1 CR +1 03/24/14, 15:09

    Might be handy for special situations, now that opcache might indeed cause trouble in certain situations (PHP 5.5's opcache).
  17. Ernesto Baschny commented on patch set 5 03/24/14, 15:09

    I tested with APC, works great
  18. Xavier Perseguers voted on patch set 5 V +1 CR +1 03/24/14, 15:14

  19. Markus Klein voted on patch set 5 V +2 CR +2 03/24/14, 15:33

  20. Markus Klein merged patch set 6 03/24/14, 15:33