28521[BUGFIX] Clean MP parameter for rootline cache identifier
Commit message
Review
-
Code review CR +2
- Jigal van Hemert +2
- Alexander Opitz +1
- Markus Klein +1
- Jost Baron +1
-
Verified V +2
- Jigal van Hemert +2
- Alexander Opitz +1
- Markus Klein +1
- Jost Baron +1
Issues 1
Files 2
Review log 19
-
Mr. Jenkins commented on patch set 1 03/19/14, 13:46
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15328/ : SUCCESS -
Jost Baron commented on patch set 1 CR -1 03/24/14, 22:06
I'm not sure if it is a good idea to use an underscore as replacement. I think it can lead to hard-to-find bugs in some weird environments, where two different cache entries get the same identifier. It would be better to replace the commata with a character that cannot appear in the cache identifier by other means, just to be sure. Possible choices are '%', '&' and a backslash. -
Markus Klein commented on patch set 1 03/25/14, 09:40
I suggest to use double underscore. No other magic characters please -
Alexander Stehlik uploaded patch set 2 03/25/14, 09:41
-
Alexander Stehlik commented on patch set 2 03/25/14, 09:41
Hehe, this was one second too late, Markus ;) -
Alexander Stehlik uploaded patch set 3 03/25/14, 09:42
-
Alexander Stehlik commented on patch set 2 03/25/14, 09:43
Now using two underscores as suggested by Markus and improved unit test. -
Markus Klein commented on patch set 3 03/25/14, 09:43
RootlineUtility.php:184without $this here too -
Alexander Stehlik uploaded patch set 4 03/25/14, 09:47
-
Alexander Stehlik commented on patch set 4 03/25/14, 09:48
Replaced invalid $this->mountPointParameter usage. -
Markus Klein commented on patch set 4 CR +1 03/25/14, 09:53
testing -
Markus Klein voted on patch set 4 V +1 03/25/14, 09:55
-
Mr. Jenkins commented on patch set 2 03/25/14, 09:59
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15687/ : SUCCESS -
Mr. Jenkins commented on patch set 3 03/25/14, 10:04
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15688/ : SUCCESS -
Alexander Opitz voted on patch set 4 V +1 CR +1 03/25/14, 10:04
-
Mr. Jenkins commented on patch set 4 03/25/14, 10:18
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15690/ : SUCCESS -
Jost Baron commented on patch set 4 V +1 CR +1 03/25/14, 13:45
Would be nice if this goes into 6.2.0 :-) -
Jigal van Hemert commented on patch set 4 V +2 CR +2 03/25/14, 14:04
Enough votes. -
Jigal van Hemert merged patch set 5 03/25/14, 14:04