Review main Merged

28521[BUGFIX] Clean MP parameter for rootline cache identifier

Alexander Stehlik CR +2 V +2 Easy +20 −1 updated 03/25/14, 14:04

Commit message

Any commas in the mount point parameter are replaced with underscores
to prevent caching errors in the RootlineUtility.

Review

  • Code review CR +2
    • Jigal van Hemert +2
    • Alexander Opitz +1
    • Markus Klein +1
    • Jost Baron +1
  • Verified V +2
    • Jigal van Hemert +2
    • Alexander Opitz +1
    • Markus Klein +1
    • Jost Baron +1

Issues 1

Files 2

Review log 19

  1. Mr. Jenkins commented on patch set 1 03/19/14, 13:46

  2. Jost Baron commented on patch set 1 CR -1 03/24/14, 22:06

    I'm not sure if it is a good idea to use an underscore as replacement. I think it can lead to hard-to-find bugs in some weird environments, where two different cache entries get the same identifier. It would be better to replace the commata with a character that cannot appear in the cache identifier by other means, just to be sure. Possible choices are '%', '&' and a backslash.
  3. Markus Klein commented on patch set 1 03/25/14, 09:40

    I suggest to use double underscore. No other magic characters please
  4. Alexander Stehlik uploaded patch set 2 03/25/14, 09:41

  5. Alexander Stehlik commented on patch set 2 03/25/14, 09:41

    Hehe, this was one second too late, Markus ;)
  6. Alexander Stehlik uploaded patch set 3 03/25/14, 09:42

  7. Alexander Stehlik commented on patch set 2 03/25/14, 09:43

    Now using two underscores as suggested by Markus and improved unit test.
  8. Markus Klein commented on patch set 3 03/25/14, 09:43

    RootlineUtility.php:184

    without $this here too
  9. Alexander Stehlik uploaded patch set 4 03/25/14, 09:47

  10. Alexander Stehlik commented on patch set 4 03/25/14, 09:48

    Replaced invalid $this->mountPointParameter usage.
  11. Markus Klein commented on patch set 4 CR +1 03/25/14, 09:53

    testing
  12. Markus Klein voted on patch set 4 V +1 03/25/14, 09:55

  13. Mr. Jenkins commented on patch set 2 03/25/14, 09:59

  14. Mr. Jenkins commented on patch set 3 03/25/14, 10:04

  15. Alexander Opitz voted on patch set 4 V +1 CR +1 03/25/14, 10:04

  16. Mr. Jenkins commented on patch set 4 03/25/14, 10:18

  17. Jost Baron commented on patch set 4 V +1 CR +1 03/25/14, 13:45

    Would be nice if this goes into 6.2.0 :-)
  18. Jigal van Hemert commented on patch set 4 V +2 CR +2 03/25/14, 14:04

    Enough votes.
  19. Jigal van Hemert merged patch set 5 03/25/14, 14:04