Review main Merged Breaking

28542[!!!][BUGFIX] Respect selected target for shortcut mode 'Parent page'

Caspar Stuebs CR +2 V +2 Normal +116 −1 updated 01/02/15, 19:19

Commit message

The selected page is now respected when selecting the parent page
to use. An upgrade wizard ensures that existing shortcuts will not
break by removing the currently selected page.

The 6.2 version of this patch will only adjust the label to not
mention the "selected page" part, so the label matches
the current behaviour.

Review

  • Code review CR +2
    • Markus Klein +2
    • Anja Leichsenring +1
  • Verified V +2
    • Markus Klein +2
    • Anja Leichsenring +1

Issues 1

Files 4

Review log 22

  1. Mr. Jenkins commented on patch set 1 03/19/14, 19:05

  2. Markus Klein updated the commit message in patch set 2 07/18/14, 10:41

  3. Markus Klein rebased onto patch set 2 07/18/14, 10:41

  4. Markus Klein commented on patch set 3 CR +1 07/18/14, 10:42

    Thank you Caspar for this good catch, sorry it took so long to discover it.
  5. Markus Klein uploaded patch set 4 11/21/14, 14:34

  6. Markus Klein voted on patch set 4 CR +1 11/21/14, 14:35

  7. Stefan Neufeind commented on patch set 4 CR +1 V +1 11/21/14, 15:00

    Also checked that the shortcut-target given is respected for the other shortcut-modes. This one here was missing.
  8. Markus Klein commented on patch set 4 11/21/14, 15:06

    Ok, I fear only one thing now: Consider the case a user has (because it hasn't been working anyway) selected the parent page. If we now have that patch, the shortcut will all of a sudden not point to the parent page of the shortcut, but to the parent page of (the selected) parent page. Dangerous? Maybe for master only?
  9. Stefan Neufeind commented on patch set 4 11/21/14, 15:12

    ack, in that regard. So master-only and a side-note about the behaviour-change (though it's a bugfix)?
  10. Stefan Neufeind commented on patch set 4 11/21/14, 15:15

    For 6.2 fix the label so it doesn't say anything about "selected page"? :-) (Well, but we didn't want to change language-labels if avoidable - hmm.)
  11. Markus Klein commented on patch set 4 11/21/14, 15:17

    Maybe we now can change labels for 6.2 only
  12. Markus Klein commented on patch set 4 CR -1 11/21/14, 17:35

    Good news, we can change the labels in 6.2. So rst file here and breaking marker. label change in 6.2
  13. Markus Klein commented on patch set 4 CR -2 11/26/14, 12:36

    blocking this for a while. have to think about a proper solution for 7 and 6.2
  14. Benni Mack commented on patch set 4 12/13/14, 13:12

    markus: did you give it any thought?
  15. Markus Klein commented on patch set 4 CR -1 12/14/14, 00:10

    For 7: Use this change and add an rst file for the "now correct behaviour" For 6.2 and below: Change the label, such that it reflects the functionality really implemented.
  16. Markus Klein commented on patch set 4 12/14/14, 11:54

    And I forgot to mention: For 7 we need an upgrade wizard that clears the selected page when shortcutmode, such that we maintain the behaviour for existing pages
  17. Markus Klein uploaded patch set 5 12/14/14, 13:09

  18. Anja Leichsenring voted on patch set 5 CR +1 V +1 12/14/14, 13:16

  19. Mathias Schreiber wrote 12/17/14, 14:33

    Topic set to EXT: install
  20. Markus Klein wrote 01/02/15, 19:18

    Topic EXT: install removed
  21. Markus Klein voted on patch set 5 CR +2 V +2 01/02/15, 19:18

  22. Markus Klein merged patch set 5 01/02/15, 19:19