Review main Merged

28556[TASK] Remove superfluous margin above #typo3-menu

mostwanted CR +2 V +2 Easy +4 −6 updated 05/03/14, 12:27

Commit message

Added padding-top to start the first li in the menue at the bottom line
of the first grey space in the content-area

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Anja Leichsenring +1
  • Verified V +2
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Anja Leichsenring +1

Issues 1

Files 1

Review log 20

  1. Mr. Jenkins commented on patch set 1 03/20/14, 10:22

  2. mostwanted commented on patch set 1 03/20/14, 18:08

    please also have a look at the ticket at forge.typo3.org for more information. thx.
  3. Benni Mack voted on patch set 1 V +1 CR +1 03/23/14, 14:29

  4. Christian Kuhn commented on patch set 1 03/23/14, 14:35

    Please no merge without feedback from Felix Kopp, RM or another UX related guy. Ihmo it does not look better with the patch ...
  5. Wouter Wolters commented on patch set 1 CR -2 03/23/14, 14:36

    -2 to prevent merging.
  6. mostwanted commented on patch set 1 03/23/14, 14:59

    I personally would prefere a grey bar like it was e.g. in TYPO3 4.7: http://forge.typo3.org/issues/57098#note-5
  7. Felix Kopp commented on patch set 1 CR -1 03/23/14, 15:34

    The active menu item should vertically end underneath the main content below the docheader.
  8. Christian Kuhn commented on patch set 1 CR -1 03/23/14, 16:10

    so, should be drop this issue?
  9. Felix Kopp commented on patch set 1 03/23/14, 16:13

    I think the optimal solution is #55975
  10. Christian Kuhn commented on patch set 1 03/23/14, 16:51

    Could you prepare something, Felix?
  11. Nico Schober uploaded patch set 2 05/03/14, 10:13

  12. Nico Schober uploaded patch set 3 05/03/14, 10:44

  13. Christian Kuhn commented on patch set 3 V +1 CR +1 05/03/14, 11:18

    like it, added a screeni to forge. first module menu row now relates with docheader of tree.
  14. Wouter Wolters voted on patch set 3 CR 0 05/03/14, 11:21

  15. Anja Leichsenring voted on patch set 3 V +1 CR +1 05/03/14, 11:42

  16. Mr. Jenkins commented on patch set 2 05/03/14, 11:58

  17. Wouter Wolters commented on patch set 3 V +1 CR +1 05/03/14, 12:10

    Tested in IE8-IE10 and FF
  18. Christian Kuhn voted on patch set 3 V +2 CR +2 05/03/14, 12:23

  19. Christian Kuhn merged patch set 4 05/03/14, 12:23

  20. Mr. Jenkins commented on patch set 3 05/03/14, 12:27