Review main Abandoned

28559[BUGFIX] Wrong grouping in new element wizard

Stefan Froemken CR 0 V 0 Easy +1 −4 updated 03/26/14, 22:35

Commit message

If the title of a table has no localization,
the corresponding table is grouped with tables
of a wrong extension.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 9

  1. Xavier Perseguers updated the commit message in patch set 1 03/20/14, 12:21

  2. Xavier Perseguers commented on patch set 2 03/20/14, 12:23

    NewRecordController.php:431

    Indeed of no use

    NewRecordController.php:483

    Don't like multiple assignments on a single line.
  3. Mr. Jenkins commented on patch set 1 03/20/14, 12:27

  4. Mr. Jenkins commented on patch set 2 03/20/14, 12:39

  5. Wouter Wolters commented on patch set 2 03/22/14, 14:22

    Is this not already fixed with: https://review.typo3.org/#/c/28510/4 ?
  6. Markus Klein commented on patch set 2 03/22/14, 18:48

    I agree with Wouter here, should be solved.
  7. Markus Klein commented on patch set 2 03/26/14, 20:58

    Ping. Stefan, can you please check if this is solved on master now.
  8. Stefan Froemken commented on patch set 2 03/26/14, 21:21

    Looks good. I have pulled the current master and the tables for my clubdirectory were not merged with tables of pt_extbase anymore. Good work. Thank you.
  9. Markus Klein abandoned the change 03/26/14, 22:35