Review main Abandoned

28561[BUGFIX] Detect possible broken TCA config

Markus Klein CR 0 V 0 Easy +26 −0 updated 09/05/18, 18:49

Commit message

RootlineUtility issues warnings if the MM relation of a column
is not configured properly.
Change this to be a meaningful syslog entry.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 10

  1. Markus Klein uploaded patch set 2 03/20/14, 12:31

  2. Markus Klein commented on patch set 2 03/20/14, 12:32

    Unittest is untested!
  3. Mr. Jenkins commented on patch set 1 03/20/14, 12:39

  4. Mr. Jenkins commented on patch set 2 03/20/14, 12:51

  5. Markus Klein uploaded patch set 3 03/20/14, 13:19

  6. Xavier Perseguers voted on patch set 3 CR +1 03/20/14, 13:27

  7. Mr. Jenkins commented on patch set 3 03/20/14, 13:30

  8. Oliver Hader commented on patch set 3 CR -1 03/20/14, 18:31

    Patch does not fix the actual problem... "group/db" tables ("allowed" in TCA configuration) was not considered before - thus, the RootlineUtility handling in this regard is broken... This patch would just log away the Core bug... A good inspiration on how to use the RelationHandler is DataHandler, there e.g. look at method "remapListedDBRecords_procDBRefs()" I'm running out of time, otherwise I would have pushed a new version with adjusted tests... sorry..

    RootlineUtility.php:269

    This code already seems to be wrong here... foreign_table is for types 'inline' and 'select', the 'group' type uses 'allowed' which is not considered...

    RootlineUtility.php:271

    Better use (!empty($loadDBGroup->tableArray[$configuration['foreign_table']]) before $relatedUids is set at all...

    RootlineUtility.php:272

    It's more a Core bug that is logged here... ;-)
  9. Markus Klein abandoned the change 04/02/14, 12:20

    Don't have time to investigate this further. Removing this patch, no need for it lying around.
  10. Andreas Kienast voted on patch set 3 CR +1 09/05/18, 18:49