28581[DECISION][WIP][FEATURE] Prevent typolinks to non translated pages
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 9
- typo3/sysext/core/Documentation/Changelog/master/Feature-28581-PreventTypolinksToNonTranslatedPages.rstnew+34 −0
- typo3/sysext/frontend/Classes/ContentObject/Menu/AbstractMenuContentObject.php+15 −39
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php+71 −0
- typo3/sysext/frontend/Classes/ContentObject/HierarchicalMenuContentObject.php+3 −0
- typo3/sysext/frontend/Classes/Typolink/PageLinkBuilder.php+7 −0
- typo3/sysext/frontend/Tests/Functional/ContentObject/ContentObjectRendererTest.php+161 −0
- typo3/sysext/frontend/Tests/Functional/Fixtures/pages.xml+76 −0
- typo3/sysext/frontend/Tests/Unit/ContentObject/Menu/AbstractMenuContentObjectTest.php+1 −0
- typo3/sysext/frontend/Tests/Unit/ContentObject/ContentObjectRendererTest.php+55 −0
Review log 2431
Show 6 earlier messages
-
Alexander Stehlik updated the commit message in patch set 1 03/20/14, 20:53
-
Mr. Jenkins commented on patch set 1 03/20/14, 21:03
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15389/ : SUCCESS -
Mr. Jenkins commented on patch set 2 03/20/14, 21:07
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15390/ : SUCCESS -
Helmut Hummel commented on patch set 2 CR -1 03/20/14, 22:54
I would not like to introduce another config option for that. If typolink behaves differntly from a MENU object links, then this should be streamlined instead. Alex, did you check the proposed patch o forge? Something wrong with that? -
Alexander Stehlik commented on patch set 2 03/20/14, 23:00
I introduced the options for performance reasons: if people do not want this feature they can save the extra computing time. But this can be removed. The patch in forge lacks some features IMHO: It does not respect the setting hideIfDefaultLanguage. It will not check if the user has provided additional parameters that override the current L parameter. But maybe it is a good idea to remove the check from the menu rendering all together and to consolidate it in the typolink function. I'll check that. Thanks for your feedback. -
Alexander Stehlik uploaded patch set 3 03/21/14, 09:18
-
Mr. Jenkins commented on patch set 3 03/21/14, 09:41
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15424/ : SUCCESS -
Alexander Stehlik uploaded patch set 4 09/29/14, 09:52
-
Alexander Stehlik commented on patch set 3 09/29/14, 09:53
Added reset for MENU registers so that items that are rendered after the menu know that they are not inside a menu. -
Mathias Schreiber wrote 12/17/14, 20:37
Topic set to cObj -
Alexander Opitz commented on patch set 4 07/07/15, 13:14
What is the state of this patch? Can you please rebase? -
Alexander Stehlik uploaded patch set 5 07/17/15, 21:25
-
Alexander Opitz commented on patch set 5 07/28/15, 12:41
Does the WIP part of the commit message falls in the patches around language_fallback chain? -
Alexander Stehlik uploaded patch set 6 12/21/15, 09:02
-
Alexander Stehlik uploaded patch set 7 09/01/16, 19:43
-
TYPO3com voted on patch set 7 V -1 09/01/16, 19:46 Completed build in 03m 18s on Thu, 1 Sep, 09:46 PM Test Summary: 39 of 19170 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2675
-
Alexander Stehlik uploaded patch set 8 09/01/16, 19:57
-
TYPO3com voted on patch set 8 V -1 09/01/16, 20:01 Completed build in 03m 37s on Thu, 1 Sep, 10:01 PM Test Summary: 19170 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2676
-
Alexander Stehlik uploaded patch set 9 09/01/16, 20:14
-
TYPO3com voted on patch set 9 V +1 09/01/16, 20:18 Completed build in 03m 12s on Thu, 1 Sep, 10:18 PM Test Summary: 19170 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2682
-
Alexander Stehlik uploaded patch set 10 12/04/16, 19:51
-
TYPO3com voted on patch set 10 V +1 12/04/16, 19:55 Completed build in 04m 14s on Sun, 4 Dec, 08:55 PM Test Summary: 54424 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5519
-
Benni Mack commented on patch set 10 11/29/17, 00:15
Care to rebase? How does this take the l18n_cfg field of pages into account? -
Mathias Schreiber uploaded patch set 11 02/10/18, 10:54
-
Mathias Schreiber commented on patch set 11 V -1 CR -1 02/10/18, 10:56
Tests feel VERY odd. It seems they test two things at once... Overlaying AND typolink at the same time. I have the feeling that this is not "correct". -
TYPO3com voted on patch set 11 V -1 02/10/18, 11:02 Completed build in 07m 42s on Sat, 10 Feb, 12:02 PM Test Summary: 19 of 30712 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19266
-
Mathias Schreiber uploaded patch set 12 02/10/18, 14:08
-
Mathias Schreiber updated the commit message in patch set 13 02/10/18, 14:08
-
TYPO3com voted on patch set 12 V -1 02/10/18, 14:17 Completed build in 09m 01s on Sat, 10 Feb, 03:17 PM Test Summary: 22 of 30676 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19283
-
TYPO3com voted on patch set 13 V -1 02/10/18, 14:18 Completed build in 10m 02s on Sat, 10 Feb, 03:18 PM Test Summary: 22 of 30676 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19284
-
Christian Kuhn abandoned the change 09/17/18, 00:08
hey. i'm abandoning this stalled patch for now and will reject the issue: nothing really happened here again for quite a while, and the situation might also have changed a bit with the v9 site configuration and some other fallback modes a bit again. i may be wrong with this decision, so please open a new issue summarizing the available information again to start this a-new if further work happens in this area.