Review main Abandoned

28584[TASK] Improve getCurrentPageId for backend context

Nicole Hummel CR 0 V 0 Easy +2 −2 updated 03/20/14, 22:35

Commit message

If there isn't any id parameter for the current request, extbase tries
to fetch the first siteroot to determine the plugin configuration. The
patch adds sorting by the table column sorting to really fetch the first
one.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 8

  1. Christian Kuhn commented on patch set 1 CR -1 03/20/14, 22:04

    windows linebreaks ^^
  2. Christian Kuhn commented on patch set 1 03/20/14, 22:04

    -1 on karma :P
  3. Wouter Wolters commented on patch set 1 03/20/14, 22:05

    Nicole also see Benni his WIP https://review.typo3.org/#/c/27243/
  4. Nicole Hummel uploaded patch set 2 03/20/14, 22:08

  5. Christian Kuhn voted on patch set 2 CR +1 03/20/14, 22:10

  6. Nicole Hummel abandoned the change 03/20/14, 22:13

    Change will be added to https://review.typo3.org/#/c/27243/
  7. Mr. Jenkins commented on patch set 1 03/20/14, 22:24

  8. Mr. Jenkins commented on patch set 2 03/20/14, 22:35