Review main Merged

28587[BUGFIX] Invalid HTML for the top toolbar in Backend

Eric Chavaillaz CR +2 V +2 Easy +16 −12 updated 09/05/18, 18:49

Commit message

Additional attributes must be concatenated with a leading blank
space in order to get valid HTML content.

Review

  • Code review CR +2
    • Xavier Perseguers +2
    • Eric Chavaillaz +1
    • Andreas Kienast +1
  • Verified V +2
    • Xavier Perseguers +2
    • Eric Chavaillaz +1
    • Andreas Kienast +1

Files 7

Review log 21

  1. Mr. Jenkins commented on patch set 1 03/21/14, 07:54

  2. Eric Chavaillaz uploaded patch set 2 03/21/14, 08:45

  3. Eric Chavaillaz uploaded patch set 3 03/21/14, 09:02

  4. Mr. Jenkins commented on patch set 2 03/21/14, 09:14

  5. Mr. Jenkins commented on patch set 3 03/21/14, 09:27

  6. Xavier Perseguers commented on patch set 3 03/21/14, 09:54

    Although it looks "good", I'm still trying to understand how to reproduce this bug
  7. Xavier Perseguers uploaded patch set 4 03/21/14, 10:42

  8. Xavier Perseguers commented on patch set 4 03/21/14, 10:48

    BackendController.php:317 Reply

    No, if you have $additionalAttributes = id="someid", and go to the else branch, you need to end up with id="someid" class="separator" and below you'll get <blank space>id="someid" class="separator" which may then be concatenated to "<li"
  9. Mr. Jenkins commented on patch set 4 03/21/14, 10:56

  10. Eric Chavaillaz commented on patch set 4 03/21/14, 10:58

    You can also delete the space in the getAdditionalAttributes() method of those files: - typo3/sysext/backend/Classes/Toolbar/LiveSearchToolbarItem.php - typo3/sysext/backend/Classes/Toolbar/ShortcutToolbarItem.php - typo3/sysext/opendocs/Classes/Controller/OpenDocsController.php - typo3/sysext/sys_action/Classes/ActionToolbarMenu.php - typo3/sysext/workspaces/Classes/ExtDirect/WorkspaceSelectorToolbarItem.php Thanks
  11. Xavier Perseguers uploaded patch set 5 03/21/14, 12:23

  12. Mr. Jenkins commented on patch set 5 03/21/14, 12:38

  13. Eric Chavaillaz voted on patch set 5 V +1 CR +1 03/21/14, 15:00

  14. Xavier Perseguers voted on patch set 5 V +2 CR +2 03/21/14, 15:03

  15. Xavier Perseguers merged patch set 6 03/21/14, 15:03

  16. Andreas Kienast commented on patch set 1 CR +1 09/05/18, 18:49

    BackendController.php:314

    Maybe add a space here, too?

    BackendController.php:317

    Maybe remove the space before "class" here, since it's added below anyway

    BackendController.php:317 Reply

    I overlooked the dot in .=, sorry.
  17. Andreas Kienast commented on patch set 3 1 comment 09/05/18, 18:49

  18. Andreas Kienast commented on patch set 3 09/05/18, 18:49

    @Xavier: Just go into the backend, View Source and search for "clear-cache-actions-menu". I made you a screenshot: http://i.imgur.com/5J6FHuR.png
  19. Andreas Kienast commented on patch set 4 1 comment 09/05/18, 18:49

  20. Andreas Kienast voted on patch set 4 V +1 CR +1 1 comment 09/05/18, 18:49

  21. Andreas Kienast voted on patch set 5 V +1 CR +1 09/05/18, 18:49