28587[BUGFIX] Invalid HTML for the top toolbar in Backend
Commit message
Review
-
Code review CR +2
- Xavier Perseguers +2
- Eric Chavaillaz +1
- Andreas Kienast +1
-
Verified V +2
- Xavier Perseguers +2
- Eric Chavaillaz +1
- Andreas Kienast +1
Files 7
- typo3/sysext/backend/Classes/Controller/BackendController.php4+10 −6
- typo3/sysext/backend/Classes/Toolbar/ClearCacheToolbarItem.php+1 −1
- typo3/sysext/backend/Classes/Toolbar/LiveSearchToolbarItem.php+1 −1
- typo3/sysext/backend/Classes/Toolbar/ShortcutToolbarItem.php+1 −1
- typo3/sysext/opendocs/Classes/Controller/OpendocsController.php+1 −1
- typo3/sysext/sys_action/Classes/ActionToolbarMenu.php+1 −1
- typo3/sysext/workspaces/Classes/ExtDirect/WorkspaceSelectorToolbarItem.php+1 −1
Review log 21
-
Mr. Jenkins commented on patch set 1 03/21/14, 07:54
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15411/ : SUCCESS -
Eric Chavaillaz uploaded patch set 2 03/21/14, 08:45
-
Eric Chavaillaz uploaded patch set 3 03/21/14, 09:02
-
Mr. Jenkins commented on patch set 2 03/21/14, 09:14
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15421/ : SUCCESS -
Mr. Jenkins commented on patch set 3 03/21/14, 09:27
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15422/ : SUCCESS -
Xavier Perseguers commented on patch set 3 03/21/14, 09:54
Although it looks "good", I'm still trying to understand how to reproduce this bug -
Xavier Perseguers uploaded patch set 4 03/21/14, 10:42
-
Xavier Perseguers commented on patch set 4 03/21/14, 10:48
BackendController.php:317ReplyNo, if you have $additionalAttributes = id="someid", and go to the else branch, you need to end up with id="someid" class="separator" and below you'll get <blank space>id="someid" class="separator" which may then be concatenated to "<li" -
Mr. Jenkins commented on patch set 4 03/21/14, 10:56
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15429/ : SUCCESS -
Eric Chavaillaz commented on patch set 4 03/21/14, 10:58
You can also delete the space in the getAdditionalAttributes() method of those files: - typo3/sysext/backend/Classes/Toolbar/LiveSearchToolbarItem.php - typo3/sysext/backend/Classes/Toolbar/ShortcutToolbarItem.php - typo3/sysext/opendocs/Classes/Controller/OpenDocsController.php - typo3/sysext/sys_action/Classes/ActionToolbarMenu.php - typo3/sysext/workspaces/Classes/ExtDirect/WorkspaceSelectorToolbarItem.php Thanks -
Xavier Perseguers uploaded patch set 5 03/21/14, 12:23
-
Mr. Jenkins commented on patch set 5 03/21/14, 12:38
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15437/ : SUCCESS -
Eric Chavaillaz voted on patch set 5 V +1 CR +1 03/21/14, 15:00
-
Xavier Perseguers voted on patch set 5 V +2 CR +2 03/21/14, 15:03
-
Xavier Perseguers merged patch set 6 03/21/14, 15:03
-
Andreas Kienast commented on patch set 1 CR +1 09/05/18, 18:49
BackendController.php:314Maybe add a space here, too?BackendController.php:317Maybe remove the space before "class" here, since it's added below anywayBackendController.php:317ReplyI overlooked the dot in .=, sorry. -
Andreas Kienast commented on patch set 3 1 comment 09/05/18, 18:49
-
Andreas Kienast commented on patch set 3 09/05/18, 18:49
@Xavier: Just go into the backend, View Source and search for "clear-cache-actions-menu". I made you a screenshot: http://i.imgur.com/5J6FHuR.png -
Andreas Kienast commented on patch set 4 1 comment 09/05/18, 18:49
-
Andreas Kienast voted on patch set 4 V +1 CR +1 1 comment 09/05/18, 18:49
-
Andreas Kienast voted on patch set 5 V +1 CR +1 09/05/18, 18:49