Review main Merged

28610[TASK] Improve clipboard names

Tymoteusz Motylewski CR +2 V +2 Easy +20 −2 updated 03/23/14, 18:38

Commit message

Makes clipboard names more meaningful for editors.
It also makes "Normal" clipboard name translatable
and adds titles with additional description to the clipboard links.

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Wouter Wolters +1
  • Verified V +2
    • Stefan Neufeind +2
    • Wouter Wolters +1

Issues 1

Files 2

Review log 15

  1. Mr. Jenkins commented on patch set 1 03/21/14, 16:14

  2. Alexander Stehlik voted on patch set 1 V +1 CR +1 03/21/14, 17:28

  3. Christian Kuhn voted on patch set 1 V +1 CR +1 03/21/14, 20:02

  4. Wouter Wolters voted on patch set 1 V +1 CR +1 03/21/14, 20:06

  5. Ernesto Baschny commented on patch set 1 CR -2 03/21/14, 20:07

    locallang_core.xlf:302

    We cannot modify translation labels, as they are shared amongst all TYPO3 releases! Create a new one (and leave the old one there) in case you need a different text. Also translators should be required to create a new translation for this instead of updating the old one.
  6. Tymoteusz Motylewski commented on patch set 1 03/22/14, 12:26

    locallang_core.xlf:302 Reply

    ok, fair point, I'll upload a new patchset
  7. Tymoteusz Motylewski uploaded patch set 2 03/22/14, 12:33

  8. Tymoteusz Motylewski commented on patch set 2 03/22/14, 12:34

    taken Ernesto comment into account - created new language label instead of reusing the old one.
  9. Mr. Jenkins commented on patch set 2 03/22/14, 12:47

  10. Wouter Wolters voted on patch set 2 V +1 CR +1 03/22/14, 13:07

  11. Stefan Neufeind voted on patch set 2 CR +1 03/23/14, 18:03

  12. Ernesto Baschny voted on patch set 2 CR 0 03/23/14, 18:21

  13. Felix Kopp commented on patch set 2 03/23/14, 18:23

    Why not remove "normal"
  14. Stefan Neufeind voted on patch set 2 V +2 CR +2 03/23/14, 18:38

  15. Stefan Neufeind merged patch set 3 03/23/14, 18:38