28638[FEATURE] HMENU special=browse does not respect exclude lists
Commit message
Review
-
Code review CR +2
- Stefan Froemken +2
- Stefan Neufeind +1
- Mathias Schreiber +1
-
Verified V +2
- Stefan Froemken +2
- Mathias Schreiber +1
Issues 1
Files 2
Review log 19
-
Mr. Jenkins commented on patch set 1 03/22/14, 13:00
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15515/ : SUCCESS -
Pascal Dürsteler commented on patch set 1 03/24/14, 13:42
"won't work" means "will work with this patch" or "still won't work even with this patch" (which then IMHO you should remove that line since it does not really relate to the patch) ? -
Jigal van Hemert commented on patch set 1 CR -1 05/21/14, 09:34
As explained, it's a feature. Also, please make the commit message describe the solution and not the problem (it's confusing as it states that options fixed in this patch are "not working now")This option is only documented for special=updated and special=keywords. Adding it to another menu type is a feature and needs to go to the next version (otherwise this option will not be available in all 6.1.x/6.2.x releases) Now it also needs a matching documentation issue.Reply
Problem is that this commit message only describes the problem instead of the solution.AbstractMenuContentObject.php:751This option is only documented for special = updated and special = keywords, making this patch a feature. -
Xavier Perseguers commented on patch set 1 05/21/14, 09:41
Proposaldoes not work IF the next element is a spacer. This patch allows spacers to be excluded and adds support for following TypoScript options: HMENU... -
Jo Hasenau commented on patch set 1 CR -1 05/21/14, 10:43
Wouldn't this bug be solved automagically by applying this fix: https://review.typo3.org/#/c/30098/ ? IMHO it makes sense, since the filterMenuPages method is already used to do all these things, but it is just not applied to the different sections of the browse menu yet. -
Benni Mack uploaded patch set 2 09/09/14, 14:38
-
Benni Mack commented on patch set 2 11/09/14, 13:23
@Joey, unfortunately, it doesn't solve the problem, because the other fix does the logical AFTER the query (thus, if you fetch the prev and the next, and the prev is "no search" then nothing is returned instead of the prevprev page). -
Benni Mack updated the commit message in patch set 3 11/09/14, 13:23
-
Stefan Neufeind commented on patch set 3 11/23/14, 23:10
Turn this into positive: Mention what is added (the added value), not what wasn't possible before :-) -
Benni Mack commented on patch set 3 11/25/14, 12:41
we need a RsT file now. Will come up with a new version for 7.1 -
Mathias Schreiber wrote 12/17/14, 20:36
Topic set to cObj -
Benni Mack uploaded patch set 4 01/01/15, 20:01
-
Benni Mack uploaded patch set 5 01/03/15, 14:36
-
Stefan Froemken commented on patch set 5 CR +1 V +1 01/05/15, 08:50
Cool idea to filter out the page with help of SQL instead of PHP -
Stefan Neufeind voted on patch set 5 CR +1 01/05/15, 08:57
-
Stefan Neufeind commented on patch set 5 01/05/15, 09:00
Feature-57178-SpecialHmenuExcludeSpecialParameters.rst:8afaik the English term is always "neither ... nor" -
Mathias Schreiber commented on patch set 5 CR +1 V +1 01/05/15, 10:49
Feature-57178-SpecialHmenuExcludeSpecialParameters.rst:8Replynope, fine the way it is. But honestly: great you take care on typos in the docs :) -
Stefan Froemken voted on patch set 5 CR +2 V +2 01/05/15, 14:47
-
Stefan Froemken merged patch set 5 01/05/15, 14:47