28639[BUGFIX] Module Menu throws PHP warning for top level menu items
Commit message
Review
-
Code review CR +2
- Xavier Perseguers +2
- Stefan Neufeind +1
- Markus Klein +1
-
Verified V +2
- Xavier Perseguers +2
- Markus Klein +1
Issues 1
Files 1
Review log 8
-
Mr. Jenkins commented on patch set 1 03/22/14, 13:07
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15516/ : SUCCESS -
Markus Klein commented on patch set 1 03/22/14, 18:34
ModuleMenuView.php:286So if $GLOBALS['LANG']->moduleLabels['tabs_images'][$moduleKey] is not set, we already have a PHP notice in line 285. -
Markus Klein uploaded patch set 2 03/22/14, 19:22
-
Mr. Jenkins commented on patch set 2 03/22/14, 19:36
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15533/ : SUCCESS -
Markus Klein voted on patch set 2 V +1 CR +1 03/22/14, 20:05
-
Stefan Neufeind commented on patch set 2 CR +1 03/23/14, 09:47
Didn't get the warnings here when testing. But patch looks okay. -
Xavier Perseguers voted on patch set 2 V +2 CR +2 03/23/14, 10:10
-
Xavier Perseguers merged patch set 3 03/23/14, 10:10