Review main Merged

28641[TASK] Fix duplicated array keys in tests

Tymoteusz Motylewski CR +2 V +2 Easy +16 −30 updated 03/22/14, 17:35

Commit message

In few tests dataproviders have duplicated array keys,
which results in some cases not being tested.
This patch removes duplicated entries and changes array
key names where needed.

Review

  • Code review CR +2
    • Christian Kuhn +2
  • Verified V +2
    • Christian Kuhn +2

Issues 1

Files 6

Review log 4

  1. Mr. Jenkins commented on patch set 1 03/22/14, 14:02

  2. Christian Kuhn commented on patch set 1 V +2 CR +2 03/22/14, 16:36

    Good catch. Did hhvm help you finding those?
  3. Christian Kuhn merged patch set 2 03/22/14, 16:37

  4. Tymoteusz Motylewski commented on patch set 2 03/22/14, 17:35

    this time it was PHPStorm:) I found one duplicated key, and then run inspection for all files to find if there are more.