Review main Merged

28655[TASK] Rename GeneralUtility in Documentation sysext

Markus Klein CR +2 V +2 Easy +23 −21 updated 03/23/14, 16:12

Commit message

Rename the GeneralUtility class in the Documentation sysext to avoid
confusion with GeneralUtility used in the Core sysext.

Review

  • Code review CR +2
    • Philipp Gampe +2
    • Christian Kuhn +1
    • Xavier Perseguers +1
  • Verified V +2
    • Philipp Gampe +2
    • Christian Kuhn +1
    • Xavier Perseguers +1

Issues 1

Files 4

Review log 12

  1. Mr. Jenkins commented on patch set 1 03/23/14, 00:54

  2. Xavier Perseguers uploaded patch set 2 03/23/14, 09:16

  3. Xavier Perseguers voted on patch set 2 V +1 CR +1 03/23/14, 09:16

  4. Stefan Neufeind commented on patch set 2 V +1 CR +1 03/23/14, 09:28

    Definitely good to avoid the confusion. Seems to still work for me as before.
  5. Mr. Jenkins commented on patch set 2 03/23/14, 09:29

  6. Christian Kuhn commented on patch set 2 03/23/14, 14:04

    Misc should be MiscUtility instead ... and all in all this is not really much better, we should ask ourself why we need such a Utility for "stuff" in the first place. But still, if you want to mitigate the current name clash for easier usage in IDE's, its ok for me.
  7. Christian Kuhn uploaded patch set 3 03/23/14, 14:07

  8. Xavier Perseguers voted on patch set 3 V +1 CR +1 03/23/14, 14:12

  9. Christian Kuhn commented on patch set 3 V +1 CR +1 03/23/14, 14:14

    I've pushed an updated patch to rename to MiscUtility. What I mean with "should not be needed in the first place": * The getIcon thing is clearly a view topic, it should be a view helper. Havin this method is a sign that some mvc pattern is violated. * The getExtensionMetaData() is probably a model topic, so having this method is a sign that model or repository abstraction in the extension is not clean. Still, +1 for now ... the points above are "just" architectural things when thinking about the issue itself.
  10. Mr. Jenkins commented on patch set 3 03/23/14, 14:21

  11. Philipp Gampe voted on patch set 3 V +2 CR +2 03/23/14, 16:12

  12. Philipp Gampe merged patch set 4 03/23/14, 16:12