28655[TASK] Rename GeneralUtility in Documentation sysext
Commit message
Review
-
Code review CR +2
- Philipp Gampe +2
- Christian Kuhn +1
- Xavier Perseguers +1
-
Verified V +2
- Philipp Gampe +2
- Christian Kuhn +1
- Xavier Perseguers +1
Issues 1
Files 4
- typo3/sysext/documentation/Classes/Controller/DocumentController.php+3 −3
- typo3/sysext/documentation/Classes/Domain/Repository/DocumentRepository.php+12 −10
- typo3/sysext/documentation/Classes/Service/DocumentationService.php+5 −5
- typo3/sysext/documentation/Classes/Utility/MiscUtility.phprenamed+3 −3
Review log 12
-
Mr. Jenkins commented on patch set 1 03/23/14, 00:54
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15541/ : SUCCESS -
Xavier Perseguers uploaded patch set 2 03/23/14, 09:16
-
Xavier Perseguers voted on patch set 2 V +1 CR +1 03/23/14, 09:16
-
Stefan Neufeind commented on patch set 2 V +1 CR +1 03/23/14, 09:28
Definitely good to avoid the confusion. Seems to still work for me as before. -
Mr. Jenkins commented on patch set 2 03/23/14, 09:29
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15543/ : SUCCESS -
Christian Kuhn commented on patch set 2 03/23/14, 14:04
Misc should be MiscUtility instead ... and all in all this is not really much better, we should ask ourself why we need such a Utility for "stuff" in the first place. But still, if you want to mitigate the current name clash for easier usage in IDE's, its ok for me. -
Christian Kuhn uploaded patch set 3 03/23/14, 14:07
-
Xavier Perseguers voted on patch set 3 V +1 CR +1 03/23/14, 14:12
-
Christian Kuhn commented on patch set 3 V +1 CR +1 03/23/14, 14:14
I've pushed an updated patch to rename to MiscUtility. What I mean with "should not be needed in the first place": * The getIcon thing is clearly a view topic, it should be a view helper. Havin this method is a sign that some mvc pattern is violated. * The getExtensionMetaData() is probably a model topic, so having this method is a sign that model or repository abstraction in the extension is not clean. Still, +1 for now ... the points above are "just" architectural things when thinking about the issue itself. -
Mr. Jenkins commented on patch set 3 03/23/14, 14:21
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15564/ : SUCCESS -
Philipp Gampe voted on patch set 3 V +2 CR +2 03/23/14, 16:12
-
Philipp Gampe merged patch set 4 03/23/14, 16:12