Review main Merged

28656[BUGFIX] preparseQuery wrongly computes cache hash of a query

Xavier Perseguers CR +2 V +2 Normal +97 −5 updated 03/23/14, 17:08

Commit message

preparseQuery only takes query's parameters to compute its hash but
not the operators used. As such, those two queries result into the
same cache hash:

SELECT * FROM fe_groups WHERE uid = :uid

SELECT * FROM fe_groups WHERE uid IN (:uid)

Review

  • Code review CR +2
    • Felix Oertel +2
    • Markus Klein +1
    • Philipp Gampe +1
  • Verified V +2
    • Felix Oertel +2
    • Philipp Gampe +1

Files 2

Review log 23

  1. Mr. Jenkins commented on patch set 1 03/23/14, 09:12

  2. Stefan Neufeind commented on patch set 1 CR +1 03/23/14, 09:26

    Must have been quite some digging for the root-cause. Thanks a lot. Makes sense by reading, giving your detailed explanation.
  3. Xavier Perseguers uploaded patch set 2 03/23/14, 09:33

  4. Stefan Neufeind voted on patch set 2 CR +1 03/23/14, 09:41

  5. Mr. Jenkins commented on patch set 2 03/23/14, 09:47

  6. Philipp Gampe commented on patch set 2 03/23/14, 11:36

    unit test?

    Typo3DbQueryParser.php:125

    missing phpdoc adaption to new return value array
  7. Markus Klein uploaded patch set 3 03/23/14, 12:20

  8. Markus Klein voted on patch set 3 CR +1 03/23/14, 12:26

  9. Stefan Neufeind commented on patch set 3 CR +1 03/23/14, 12:32

    Tried build a unittest. But it's not as trivial as it seemed on first look.
  10. Mr. Jenkins commented on patch set 3 03/23/14, 12:33

  11. Felix Oertel uploaded patch set 4 03/23/14, 14:48

  12. Felix Oertel commented on patch set 4 V +2 CR +2 03/23/14, 14:51

    Good catch!
  13. Felix Oertel uploaded patch set 5 03/23/14, 14:52

  14. Felix Oertel voted on patch set 5 V +2 CR +2 03/23/14, 14:53

  15. Xavier Perseguers voted on patch set 5 V +1 CR +1 03/23/14, 14:59

  16. Felix Oertel uploaded patch set 6 03/23/14, 15:00

  17. Felix Oertel voted on patch set 6 V +2 CR +2 03/23/14, 15:00

  18. Mr. Jenkins commented on patch set 4 03/23/14, 15:02

  19. Mr. Jenkins commented on patch set 5 03/23/14, 15:06

  20. Markus Klein voted on patch set 6 CR +1 03/23/14, 15:18

  21. Mr. Jenkins commented on patch set 6 03/23/14, 15:20

  22. Philipp Gampe voted on patch set 6 V +1 CR +1 03/23/14, 17:08

  23. Xavier Perseguers merged patch set 7 03/23/14, 17:08