28656[BUGFIX] preparseQuery wrongly computes cache hash of a query
Commit message
Review
-
Code review CR +2
- Felix Oertel +2
- Markus Klein +1
- Philipp Gampe +1
-
Verified V +2
- Felix Oertel +2
- Philipp Gampe +1
Files 2
Review log 23
-
Mr. Jenkins commented on patch set 1 03/23/14, 09:12
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15542/ : SUCCESS -
Stefan Neufeind commented on patch set 1 CR +1 03/23/14, 09:26
Must have been quite some digging for the root-cause. Thanks a lot. Makes sense by reading, giving your detailed explanation. -
Xavier Perseguers uploaded patch set 2 03/23/14, 09:33
-
Stefan Neufeind voted on patch set 2 CR +1 03/23/14, 09:41
-
Mr. Jenkins commented on patch set 2 03/23/14, 09:47
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15544/ : SUCCESS -
Philipp Gampe commented on patch set 2 03/23/14, 11:36
unit test?Typo3DbQueryParser.php:125missing phpdoc adaption to new return value array -
Markus Klein uploaded patch set 3 03/23/14, 12:20
-
Markus Klein voted on patch set 3 CR +1 03/23/14, 12:26
-
Stefan Neufeind commented on patch set 3 CR +1 03/23/14, 12:32
Tried build a unittest. But it's not as trivial as it seemed on first look. -
Mr. Jenkins commented on patch set 3 03/23/14, 12:33
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15557/ : SUCCESS -
Felix Oertel uploaded patch set 4 03/23/14, 14:48
-
Felix Oertel commented on patch set 4 V +2 CR +2 03/23/14, 14:51
Good catch! -
Felix Oertel uploaded patch set 5 03/23/14, 14:52
-
Felix Oertel voted on patch set 5 V +2 CR +2 03/23/14, 14:53
-
Xavier Perseguers voted on patch set 5 V +1 CR +1 03/23/14, 14:59
-
Felix Oertel uploaded patch set 6 03/23/14, 15:00
-
Felix Oertel voted on patch set 6 V +2 CR +2 03/23/14, 15:00
-
Mr. Jenkins commented on patch set 4 03/23/14, 15:02
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15566/ : SUCCESS -
Mr. Jenkins commented on patch set 5 03/23/14, 15:06
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15567/ : SUCCESS -
Markus Klein voted on patch set 6 CR +1 03/23/14, 15:18
-
Mr. Jenkins commented on patch set 6 03/23/14, 15:20
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15569/ : SUCCESS -
Philipp Gampe voted on patch set 6 V +1 CR +1 03/23/14, 17:08
-
Xavier Perseguers merged patch set 7 03/23/14, 17:08