Review TYPO3_6-1 Abandoned

28661[BUGFIX] Module Menu throws PHP warning for top level menu items

Xavier Perseguers CR 0 V 0 Easy +14 −10 updated 03/23/14, 14:40

Commit message

When rendering the module menu icons, the menu items
on the top level (Web, File, User, Admin) don't have an icon,
however the getModuleIcon functionality processes them,
and checks for getimagesize() even though no image is added.

To overcome this, the function needs to be modified slightly to
only call getimagesize if there is actually an icon.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 4

  1. Xavier Perseguers commented on patch set 1 CR +1 03/23/14, 10:12

    Straight backport from master
  2. Benni Mack uploaded patch set 2 03/23/14, 14:27

  3. Benni Mack commented on patch set 2 03/23/14, 14:30

    aah, I didn't see that, already merged the backport in another issue. can we abandon this one?
  4. Stefan Neufeind abandoned the change 03/23/14, 14:40

    Please keep the change-id when doing backports! Merged for 6.1 in https://review.typo3.org/28668