Review main Merged

28663[BUGFIX] Parsetime: config.debug should override LocalConfiguration

Stefan Neufeind CR +2 V +2 Easy +6 −1 updated 03/23/14, 14:08

Commit message

Parsetime is output either if config.debug is set or if FE-debug
is activated in LocalConfiguration. Allow to explicitly override
(set to 0) the debugging in TS for cases where you want to output
page-objects like a JSON-page or so where Parsetime leads to
problems.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Stefan Neufeind +1
    • Markus Klein +1
  • Verified V +2
    • Christian Kuhn +2
    • Markus Klein +1

Issues 1

Files 1

Review log 18

  1. Xavier Perseguers uploaded patch set 2 03/23/14, 11:49

  2. Mr. Jenkins commented on patch set 1 03/23/14, 11:52

  3. Xavier Perseguers uploaded patch set 3 03/23/14, 11:52

  4. Xavier Perseguers voted on patch set 3 V +1 CR +1 03/23/14, 11:53

  5. Xavier Perseguers uploaded patch set 4 03/23/14, 12:00

  6. Xavier Perseguers voted on patch set 4 V +1 CR +1 03/23/14, 12:00

  7. Mr. Jenkins commented on patch set 2 03/23/14, 12:06

  8. Mr. Jenkins commented on patch set 3 03/23/14, 12:12

  9. Mr. Jenkins commented on patch set 4 03/23/14, 12:25

  10. Stefan Neufeind commented on patch set 4 CR +1 03/23/14, 12:33

    Thanks for making it more easy to read.
  11. Markus Klein commented on patch set 4 03/23/14, 13:27

    index_ts.php:248

    !empty
  12. Markus Klein uploaded patch set 5 03/23/14, 13:29

  13. Markus Klein voted on patch set 5 V +1 CR +1 03/23/14, 13:29

  14. Stefan Neufeind voted on patch set 5 CR +1 03/23/14, 13:30

  15. Mr. Jenkins commented on patch set 5 03/23/14, 13:49

  16. Christian Kuhn voted on patch set 5 V +2 CR +2 03/23/14, 13:51

  17. Christian Kuhn merged patch set 6 03/23/14, 13:51

  18. Stefan Neufeind commented on patch set 6 03/23/14, 14:08

    Cherry Picked This patchset was cherry picked to change: Ie5588218694219c13f136b5ac928e697ca472cfb