Review main Merged

28666[BUGFIX] Fix incomplete mocking in several tests

Helmut Hummel CR +2 V +2 Easy +3 −3 updated 03/23/14, 13:44

Commit message

IndexerServiceTest and ExtensionManagementServiceTest
both execute emit signal methods which in turn
try to instantiate the SignalSlotDispatcher,
which can fail.

Resolve this by mocking these methods.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Markus Klein +1
  • Verified V +2
    • Christian Kuhn +2
    • Wouter Wolters +1

Issues 1

Files 2

Review log 6

  1. Markus Klein voted on patch set 1 CR +1 03/23/14, 13:25

  2. Wouter Wolters voted on patch set 1 V +1 CR +1 03/23/14, 13:25

  3. Christian Kuhn voted on patch set 1 V +1 CR +1 03/23/14, 13:25

  4. Christian Kuhn voted on patch set 1 V +2 CR +2 03/23/14, 13:25

  5. Christian Kuhn merged patch set 2 03/23/14, 13:25

  6. Mr. Jenkins commented on patch set 1 03/23/14, 13:44