Review TYPO3_6-1 Merged

28668[BUGFIX] Module Menu throws PHP warning for top level menu items

Benni Mack CR +2 V +2 Easy +14 −10 updated 03/23/14, 14:28

Commit message

When rendering the module menu icons, the menu items
on the top level (Web, File, User, Admin) don't have an icon,
however the getModuleIcon functionality processes them,
and checks for getimagesize() even though no image is added.

To overcome this, the function needs to be modified slightly to
only call getimagesize if there is actually an icon.

Review

  • Code review CR +2
    • Benni Mack +2
  • Verified V +2
    • Benni Mack +2

Issues 1

Files 1

Review log 2

  1. Benni Mack voted on patch set 1 V +2 CR +2 03/23/14, 14:27

  2. Benni Mack merged patch set 2 03/23/14, 14:28