Review main Merged

28671[BUGFIX] Invalid argument supplied for foreach in ExtensionModelUtility

Philipp Gampe CR +2 V +2 Easy +18 −0 updated 03/24/14, 12:40

Commit message

Dependecies might be given as empty string, e.g.
array (
	'depends' =>
		array (
			'typo3' => '4.5.0-6.2.99',
		),
	'conflicts' => '',
	'suggests' =>
		array (
		),
),

This is how the kickstarter used to generate it.

Review

  • Code review CR +2
    • Markus Klein +2
    • Alexander Opitz +1
    • Ernesto Baschny +1
  • Verified V +2
    • Markus Klein +2
    • Alexander Opitz +1

Issues 1

Files 2

Review log 12

  1. Philipp Gampe updated the commit message in patch set 1 03/23/14, 15:51

  2. Mr. Jenkins commented on patch set 1 03/23/14, 16:05

  3. Mr. Jenkins commented on patch set 2 03/23/14, 16:06

  4. Markus Klein voted on patch set 2 V +2 CR +2 03/24/14, 10:51

  5. Markus Klein commented on patch set 2 V 0 03/24/14, 10:52

    maybe a unit test
  6. Xavier Perseguers voted on patch set 2 CR +1 03/24/14, 10:54

  7. Markus Klein uploaded patch set 3 03/24/14, 11:00

  8. Alexander Opitz commented on patch set 3 V +1 CR +1 03/24/14, 11:05

    Warning is gone, couldn't run test.
  9. Mr. Jenkins commented on patch set 3 03/24/14, 11:14

  10. Ernesto Baschny voted on patch set 3 CR +1 03/24/14, 11:53

  11. Markus Klein voted on patch set 3 V +2 CR +2 03/24/14, 12:40

  12. Markus Klein merged patch set 4 03/24/14, 12:40