Review main Merged

2868[BUGFIX] Disabled empty number of days field in table garbage collection scheduler task

Kai Richter CR +2 V +2 Normal +35 −16 updated 06/03/13, 20:49

Commit message

collection scheduler task

This patch reactivates the number of days field even if it is
empty if a default number is provided by the selected table.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Philipp Gampe +1
  • Verified V +2
    • Christian Kuhn +2
    • Philipp Gampe +1

Issues 1

Files 3

Review log 15

  1. Philipp Gampe commented on patch set 2 06/23/11, 20:00

    how do I reproduce this?
  2. Kai Richter uploaded patch set 2 06/23/11, 20:00

  3. Philipp Gampe commented on patch set 3 06/23/11, 20:00

    Thanks for the hind. I could reproduce the problem. For me this also happens if I select the sys_log table, enter "0" and save. If I then open again, I can't change the number of days any more. This also happens after your patch. However with you patch, I am able to check all tables checkbox and after uncheck, the value is 180 again. For cache_pages I am never able to change the value.
  4. Kai Richter uploaded patch set 3 06/23/11, 20:00

  5. Kai Richter commented on patch set 3 06/23/11, 20:00

    The problem can be reproduced by selecting "sys_log" and removing the number of days. Then check and afterwards uncheck the checkbox for all tables. Now the number of days field is disabled and you can't set a value.
  6. Christian Kuhn commented on patch set 4 V 0 06/23/11, 20:00

    by team member; Looks good to me, approved
  7. Philipp Gampe commented on patch set 4 06/23/11, 20:00

    Verified; Looks good to me, but someone else must approve
  8. Philipp Gampe commented on patch set 4 06/23/11, 20:00

    one comment: It I save and reopen the task and select another table (or uncheck the all table box and select sys_log), the value is 180 again. IMHO this is ok, as it is the default value and after you selected something else you are back to default.
  9. Kai Richter commented on patch set 4 06/23/11, 20:00

    "For me this also happens if I select the sys_log table, enter 0 and save. If I then open again, I can't change the number of days any more. This also happens after your patch." -> This is now fixed "However with you patch, I am able to check all tables checkbox and after uncheck, the value is 180 again." -> I can't reproduce this problem (maybe cache?) "For cache_pages I am never able to change the value." -> That's true because there is no 'expirePeriod' defined for this table in ext_localconf.php
  10. Kai Richter uploaded patch set 4 06/23/11, 20:00

  11. Mr. Jenkins commented on patch set 1 06/23/11, 20:00

  12. Mr. Jenkins commented on patch set 2 06/23/11, 20:00

  13. Mr. Jenkins commented on patch set 3 06/23/11, 20:00

  14. Mr. Jenkins commented on patch set 4 06/23/11, 20:00

  15. Christian Kuhn merged patch set 4 06/23/11, 20:00