Review main Merged

28683[BUGFIX] Unresolvable dependency if composer.json lacks version

Claus Due CR +2 V +2 Easy +6 −1 updated 03/24/14, 12:33

Commit message

This change fixes a problem which occurs under these circumstances:

* Extension A depends on Extension B
* Extension B is currently installed
* Extension A is not currently installed
* Extension B has composer.json file
* Extension B composer.json file contains no "version" attribute
  or this attribute is empty.

When installing Extension A in this case, EM will fail with an
error saying "could not resolve dependency for xyz" which is a
bit too vague to be helpful. This change fixes this murky error
by throwing a much more specific error saying exactly that the
error stems from the composer.json file missing a "version" no.

Review

  • Code review CR +2
    • Markus Klein +2
    • Alexander Opitz +1
  • Verified V +2
    • Markus Klein +2
    • Alexander Opitz +1

Issues 1

Files 1

Review log 5

  1. Mr. Jenkins commented on patch set 1 03/23/14, 23:06

  2. Markus Klein voted on patch set 1 CR +1 03/23/14, 23:49

  3. Alexander Opitz voted on patch set 1 V +1 CR +1 03/24/14, 07:44

  4. Markus Klein voted on patch set 1 V +2 CR +2 03/24/14, 12:33

  5. Markus Klein merged patch set 2 03/24/14, 12:33