2869[DRAFT][FEATURE] Collapsing and shrinking of module menu
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 2
Review log 28
Show 3 earlier messages
-
Steffen Gebert commented on patch set 2 02/01/12, 00:07
> It is almost impossible to find the tiny line where you can drag the border line to condense the menu (I think it is only one pixel wide - here in chromium). I noticed that in Chrome, too. It seems like our artificial 10px wide area around the resize bar does not work. However, this is not related to this change. -
Kay Strobach commented on patch set 2 02/01/12, 00:07
Verified; Looks good to me, but someone else must approve ok - sry, for the cgl issues ;) - thanks for changing ;) -
Kay Strobach commented on patch set 2 02/01/12, 00:07
No score; No score followed the wiki to commit a two line patch to the last commit, but gerrit seems to use it as a different patch :( change is simply putting module = TYPO3.ModuleMenu.App.selectedModule; TYPO3.ModuleMenu.App.highlightModuleMenuItem(module); to line 200 in the file modulemenu.js ;) Hope the commit was ok anyway ... -
Philipp Gampe commented on patch set 2 02/01/12, 00:07
Fails It is almost impossible to find the tiny line where you can drag the border line to condense the menu (I think it is only one pixel wide - here in chromium). Second, the web modules get always collapsed if I condense the menu. Third the current highlighted menu item looses focus if I condense the menu, so it is hard so say where you are. However I really like the idea.viewportConfiguration.js:54remove this one pleaseviewportConfiguration.js:70whitespacemodulemenu.js:130this seems to do nothingmodulemenu.js:149really test? (I am not into ExtJS, but this seems to be a left over) OK, it existed before, maybe you can find out what it does and maybe add a comment. -
Philipp Gampe commented on patch set 2 02/01/12, 00:07
> I noticed that in Chrome, too. It seems like our artificial 10px wide area around the resize bar does not work. However, this is not related to this change. Ok, noted, but the other issues are still valid I think (and should be fixed with this patch) -
Steffen Gebert commented on patch set 3 02/01/12, 00:07
Do not submit Okay, that looks pretty good from my point of view! As we still need feedback from Jens to have the approval of the usability team, I'm blocking this one for the moment. -
Steffen Ritter commented on patch set 3 02/01/12, 00:07
I would prefer that you didn't submit this ExtJS XTemplate allow functions and ifs... I would prefer not having, two completely different templates. functions checking the state within the template and a refresh on the view should be enough and much less code duplication -
Kay Strobach commented on patch set 3 02/01/12, 00:07
No score; No score Do you mean it could be done with "Template member functions" ;) http://dev.sencha.com/deploy/ext-3.4.0/docs/?class=Ext.XTemplate Jepp it should be reworked - currently there more ideas around in the issue on forge. :( -
Kay Strobach commented on patch set 3 02/01/12, 00:07
Verified; Looks good to me, but someone else must approve perfect ;) thanks - don't know why gerrit made a different patch - must have made a mistake :( -
Oliver Hader uploaded patch set 5 02/01/12, 00:07
-
Oliver Hader commented on patch set 5 02/01/12, 00:07
Fails; Do not submit Rebasing to master V:-1, R:-2 V:0, R:-2 from Steffen Gebert <steffen.gebert@typo3.org> V:-1, R:-1 from Philipp Gampe <forge.typo3.org@philippgampe.info> -
Steffen Gebert commented on patch set 4 02/01/12, 00:07
Philipp: Resizing works not in Chrome, see #27660 -
Kay Strobach uploaded patch set 4 02/01/12, 00:07
-
Kay Strobach commented on patch set 4 02/01/12, 00:07
@Philipp: I renamed the Change to Draft - as i had a working version before, which has been visually / functionally reworked by the UI Team (see tracker). (Therefore some code is left for debugging and testing). The current problem seems to be a bug in ExtJS: http://www.sencha.com/learn/layout-faq/ -> Part: Partially Collapse a Panel Now i search a way to go around this issue. The current version works in Chrome also - with the hideCollapseToolbar in the head of the modulemenu - the split button does only collapse :( - that frustrates me a bit ;) Thanks for testing - now i hope i find a way to solve that issue. (I spent more time than for the cardlayout already :() Regards Kay -
Philipp Gampe commented on patch set 3 02/01/12, 00:07
Verified; Looks good to me, but someone else must approve -
Philipp Gampe commented on patch set 3 02/01/12, 00:07
I guess you forget to --amand and thus created a new commit on top of the old one. Or you deleted the Change-Id line. Always check with git log before pushing. -
Philipp Gampe commented on patch set 3 02/01/12, 00:07
works now :) I added the changes from the other issue and pushed the renewed patch -
Philipp Gampe uploaded patch set 3 02/01/12, 00:07
-
Philipp Gampe commented on patch set 4 4 comments 02/01/12, 00:07
Fails; I would prefer that you didn't submit this This one does not work at all: * resize does not work in Chromium 12.0.718.0, FF works * collapsed is not possible any more * condensed works, but is is not possible to get it back being big (both Chromium and FF) * after reload now icons show up if left in condensed mode (in FF too) Please review this one. I really like the idea and I am happy to test this (also on Windows + different browsers) -
Mr. Jenkins commented on patch set 1 02/01/12, 00:07
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/782/ : SUCCESS -
Mr. Jenkins commented on patch set 2 02/01/12, 00:07
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/785/ : SUCCESS -
Mr. Jenkins commented on patch set 3 02/01/12, 00:07
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/799/ : SUCCESS -
Mr. Jenkins commented on patch set 4 02/01/12, 00:07
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1297/ : SUCCESS -
Mr. Jenkins commented on patch set 5 02/01/12, 00:07
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2708/ : SUCCESS -
Steffen Gebert commented on patch set 5 02/01/12, 00:07
Abandoned Abandoned due to lack of feedback or activity.