Review main Merged

28690[TASK] Add ResourceStorage getEvaluatePermissions()

Frans Saris CR +2 V +2 Easy +31 −0 updated 03/24/14, 09:12

Commit message

#51326 introduced a setEvaluatePermissions() method
to enable/disable permission checking in the
ResourceStorage. But a getter is missing so there
is no way to get the current setting.
This is needed if you only want to disable the
checks temporary and you do not know what the
current state is.

This changes adds a getter for the evaluatePermissions
value so you can fetch the current value.

Review

  • Code review CR +2
    • Frans Saris +2
    • Alexander Opitz +1
    • Xavier Perseguers +1
  • Verified V +2
    • Frans Saris +2
    • Alexander Opitz +1
    • Xavier Perseguers +1

Issues 1

Files 2

Review log 13

  1. Frans Saris updated the commit message in patch set 1 03/24/14, 08:19

  2. Helmut Hummel updated the commit message in patch set 2 03/24/14, 08:19

  3. Alexander Opitz voted on patch set 3 V +1 CR +1 03/24/14, 08:23

  4. Alexander Opitz commented on patch set 3 03/24/14, 08:26

    Adding a test for the getter would be nice.
  5. Mr. Jenkins commented on patch set 1 03/24/14, 08:36

  6. Frans Saris uploaded patch set 4 03/24/14, 08:41

  7. Xavier Perseguers voted on patch set 4 V +1 CR +1 03/24/14, 08:43

  8. Mr. Jenkins commented on patch set 2 03/24/14, 08:46

  9. Mr. Jenkins commented on patch set 3 03/24/14, 08:51

  10. Alexander Opitz voted on patch set 4 V +1 CR +1 03/24/14, 08:54

  11. Mr. Jenkins commented on patch set 4 03/24/14, 09:05

  12. Frans Saris voted on patch set 4 V +2 CR +2 03/24/14, 09:12

  13. Frans Saris merged patch set 5 03/24/14, 09:12