Review main Merged

28731[BUGFIX] Fix warning during extension installation

Helmut Hummel CR +2 V +2 Normal +100 −6 updated 03/25/14, 01:00

Commit message

During unpacking of an extension in the installation
process it can happen that the extension data
contains folders in the file list.

These folders need to be removed from the list
in order to avoid warnings when trying to write
directories as files.

Also remove duplicates from folders before
creating them.

Besides fix some (non related) comparisons to
strict comparisons on the go.

Review

  • Code review CR +2
    • Ernesto Baschny +2
    • Philipp Gampe +1
  • Verified V +2
    • Ernesto Baschny +2
    • Philipp Gampe +1

Issues 1

Files 3

Review log 7

  1. Philipp Gampe updated the commit message in patch set 1 03/24/14, 23:50

  2. Helmut Hummel commented on patch set 2 03/24/14, 23:51

    can be tested with bootstrap_package extension, which causes warnings during install before this patch
  3. Philipp Gampe commented on patch set 2 V +1 CR +1 03/25/14, 00:11

    tested with introduction and bootstrap_package
  4. Mr. Jenkins commented on patch set 1 03/25/14, 00:39

  5. Mr. Jenkins commented on patch set 2 03/25/14, 00:41

  6. Ernesto Baschny voted on patch set 2 V +2 CR +2 03/25/14, 01:00

  7. Ernesto Baschny merged patch set 3 03/25/14, 01:00