Review main Merged

28738[BUGFIX] Extensionmanager does not show error messages on update failure

Philipp Gampe CR +2 V +2 Normal +48 −5 updated 04/29/14, 22:15

Commit message

The extension manager fails to show any error message if an extension
update fails.

Convert exceptions (e.g. dependency fails, TER download fails) into a
nice flashmessage.
Convert any server errors (uncatchable PHP errors) into a flashmessage.

Review

  • Code review CR +2
    • Markus Klein +2
    • Wouter Wolters +1
    • Jost Baron +1
  • Verified V +2
    • Markus Klein +2
    • Wouter Wolters +1

Issues 1

Files 4

Review log 20

  1. Markus Klein commented on patch set 1 03/25/14, 02:24

    DownloadController.php:185

    commented on purpose? why not removed?
  2. Mr. Jenkins commented on patch set 1 03/25/14, 02:31

  3. Philipp Gampe commented on patch set 1 03/25/14, 13:13

    DownloadController.php:185 Reply

    Of course this should not be commented ... I just used it for testing to not deactivate an extension if I let the process fatal on purpose.
  4. Philipp Gampe uploaded patch set 2 03/25/14, 13:16

  5. Philipp Gampe commented on patch set 2 03/25/14, 13:16

    uncommented prepareExtensionForImport() and moved it into the try clause
  6. Markus Klein commented on patch set 2 03/26/14, 20:55

    This one might be obsolete with: https://review.typo3.org/28883
  7. Markus Klein commented on patch set 2 04/26/14, 16:40

    Ok, it's not obsolete! Just had another error that was not displayed. Will rebase this patch
  8. Markus Klein uploaded patch set 3 04/26/14, 16:43

  9. Mr. Jenkins commented on patch set 3 04/26/14, 16:56

  10. Markus Klein voted on patch set 3 V +1 CR +1 04/26/14, 16:57

  11. Oliver Klee voted on patch set 3 CR +1 04/27/14, 08:08

  12. Jost Baron voted on patch set 3 CR +1 04/27/14, 18:47

  13. Wouter Wolters commented on patch set 3 04/29/14, 17:48

    update on the way

    main.js:191

    split over several lines.
  14. Wouter Wolters uploaded patch set 4 04/29/14, 17:48

  15. Wouter Wolters voted on patch set 4 V +1 CR +1 04/29/14, 17:48

  16. Jost Baron voted on patch set 4 CR +1 04/29/14, 17:53

  17. Markus Klein voted on patch set 4 V +1 CR +1 04/29/14, 17:58

  18. Mr. Jenkins commented on patch set 4 04/29/14, 18:14

  19. Markus Klein voted on patch set 4 V +2 CR +2 04/29/14, 22:15

  20. Markus Klein merged patch set 5 04/29/14, 22:15