28738[BUGFIX] Extensionmanager does not show error messages on update failure
Commit message
Review
-
Code review CR +2
- Markus Klein +2
- Wouter Wolters +1
- Jost Baron +1
-
Verified V +2
- Markus Klein +2
- Wouter Wolters +1
Issues 1
Files 4
- typo3/sysext/extensionmanager/Classes/Controller/DownloadController.php2+14 −2
- typo3/sysext/extensionmanager/Resources/Private/Language/locallang.xlf+3 −0
- typo3/sysext/extensionmanager/Resources/Private/Templates/Download/UpdateExtension.json+4 −1
- typo3/sysext/extensionmanager/Resources/Public/JavaScript/main.js1+27 −2
Review log 20
-
Markus Klein commented on patch set 1 03/25/14, 02:24
-
Mr. Jenkins commented on patch set 1 03/25/14, 02:31
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15680/ : SUCCESS -
Philipp Gampe commented on patch set 1 03/25/14, 13:13
DownloadController.php:185ReplyOf course this should not be commented ... I just used it for testing to not deactivate an extension if I let the process fatal on purpose. -
Philipp Gampe uploaded patch set 2 03/25/14, 13:16
-
Philipp Gampe commented on patch set 2 03/25/14, 13:16
uncommented prepareExtensionForImport() and moved it into the try clause -
Markus Klein commented on patch set 2 03/26/14, 20:55
This one might be obsolete with: https://review.typo3.org/28883 -
Markus Klein commented on patch set 2 04/26/14, 16:40
Ok, it's not obsolete! Just had another error that was not displayed. Will rebase this patch -
Markus Klein uploaded patch set 3 04/26/14, 16:43
-
Mr. Jenkins commented on patch set 3 04/26/14, 16:56
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16127/ : SUCCESS -
Markus Klein voted on patch set 3 V +1 CR +1 04/26/14, 16:57
-
Oliver Klee voted on patch set 3 CR +1 04/27/14, 08:08
-
Jost Baron voted on patch set 3 CR +1 04/27/14, 18:47
-
Wouter Wolters commented on patch set 3 04/29/14, 17:48
update on the waymain.js:191split over several lines. -
Wouter Wolters uploaded patch set 4 04/29/14, 17:48
-
Wouter Wolters voted on patch set 4 V +1 CR +1 04/29/14, 17:48
-
Jost Baron voted on patch set 4 CR +1 04/29/14, 17:53
-
Markus Klein voted on patch set 4 V +1 CR +1 04/29/14, 17:58
-
Mr. Jenkins commented on patch set 4 04/29/14, 18:14
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16154/ : SUCCESS -
Markus Klein voted on patch set 4 V +2 CR +2 04/29/14, 22:15
-
Markus Klein merged patch set 5 04/29/14, 22:15
DownloadController.php:185