Review main Merged

28743[BUGFIX] Wrong SignalSlot dispatch calls in ResourceStorage

Frans Saris CR +2 V +2 Easy +10 −10 updated 03/25/14, 14:07

Commit message

The wrong classname is used and for emitPreFolderCopySignal(),
emitPostFolderCopySignal(), emitPreFolderMoveSignal() and
emitPostFolderMoveSignal() the $newName parameter is not
passed through

Review

  • Code review CR +2
    • Steffen Ritter +2
    • Frans Saris +2
    • Markus Klein +1
    • Xavier Perseguers +1
    • Ernesto Baschny +1
  • Verified V +2
    • Frans Saris +2
    • Xavier Perseguers +1

Issues 1

Files 1

Review log 13

  1. Frans Saris uploaded patch set 2 03/25/14, 09:54

  2. Frans Saris commented on patch set 2 03/25/14, 09:59

    see forge for a extension and instructions to easy verify
  3. Xavier Perseguers voted on patch set 2 CR +1 03/25/14, 10:01

  4. Markus Klein voted on patch set 2 CR +1 03/25/14, 10:01

  5. Ernesto Baschny commented on patch set 2 CR -1 03/25/14, 10:07

    Wait for some feedback from Steffen. This is a breaking change, as these signals are also present in 6.0 and 6.1. In the case of FAL, I would agree that we could make an exception, as FAL in 6.0-6.1 is broken anyway.
  6. Steffen Ritter commented on patch set 2 CR +2 03/25/14, 10:10

    don't think it is breaking, since it might not have worked at all before
  7. Ernesto Baschny voted on patch set 2 CR +1 03/25/14, 10:11

  8. Mr. Jenkins commented on patch set 1 03/25/14, 10:28

  9. Mr. Jenkins commented on patch set 2 03/25/14, 10:33

  10. Xavier Perseguers voted on patch set 2 V +1 03/25/14, 13:51

  11. Frans Saris voted on patch set 2 V +2 CR +2 03/25/14, 13:57

  12. Frans Saris merged patch set 3 03/25/14, 13:57

  13. Mathias Brodala commented on patch set 3 03/25/14, 14:07

    Just for the record: why not simply __CLASS__?