Review main Merged

28760[BUGFIX] Install tool update wizards show html tags in error message

Frans Saris CR +2 V +2 Easy +7 −24 updated 03/26/14, 20:52

Commit message

The RteFileLinksUpdateWizard, RteMagicImagesUpdateWizard
and TceformsUpdateWizard convert there error messages to
FlashMessages. But as the messages are now always wrapped in a
flashmessage tag in the template this isn't needed anymore.

Review

  • Code review CR +2
    • Markus Klein +2
    • Alexander Opitz +1
    • Philipp Gampe +1
  • Verified V +2
    • Markus Klein +2
    • Alexander Opitz +1

Issues 1

Files 3

Review log 15

  1. Mr. Jenkins commented on patch set 1 03/25/14, 13:55

  2. Markus Klein commented on patch set 1 V -1 CR -1 03/25/14, 14:02

    TceformsUpdateWizard.php:336

    ->render() not anymore
  3. Markus Klein uploaded patch set 2 03/25/14, 14:04

  4. Mr. Jenkins commented on patch set 2 03/25/14, 14:58

  5. Markus Klein rebased onto patch set 2 03/25/14, 15:25

  6. Markus Klein voted on patch set 3 V +1 CR +1 03/25/14, 15:26

  7. Philipp Gampe commented on patch set 3 CR +1 03/25/14, 15:31

    should we use LF instead of PHP_EOL?
  8. Frans Saris commented on patch set 3 CR -1 03/25/14, 15:44

    Will push new patch

    RteMagicImagesUpdateWizard.php:162

    Should be PHP_EOL
  9. Mr. Jenkins commented on patch set 3 03/25/14, 15:44

  10. Frans Saris uploaded patch set 4 03/25/14, 15:46

  11. Mr. Jenkins commented on patch set 4 03/25/14, 16:13

  12. Philipp Gampe voted on patch set 4 CR +1 03/25/14, 17:02

  13. Alexander Opitz voted on patch set 4 V +1 CR +1 03/25/14, 21:37

  14. Markus Klein voted on patch set 4 V +2 CR +2 03/26/14, 20:52

  15. Markus Klein merged patch set 5 03/26/14, 20:52