Review main Merged

28856[BUGFIX] CSC: file references not working with image compression

Benni Mack CR +2 V +2 Easy +2 −0 updated 03/27/14, 13:44

Commit message

When using image compression with CSS styled content
all existing data in the $imgConf array is emptied.
If using a sys_file_reference, the file object
for resolving the file data does not consider
the option "treatIdAsReference" anymore as
it is unset as well.

How to reproduce: Add a file and select any image compression.
The wrong image is rendered, as the file UID is used
not the file reference UID.

If you have a sys_file UID 23, and a sys_file_reference ID 45
then the sys_file 45 is displayed instead of sys_file 23.

Review

  • Code review CR +2
    • Frans Saris +2
    • Wouter Wolters +1
    • Tom +1
    • Marc Bastian Heinrichs +1
  • Verified V +2
    • Frans Saris +2
    • Tom +1

Issues 1

Files 1

Review log 10

  1. Benni Mack uploaded patch set 2 03/26/14, 16:32

  2. Tom voted on patch set 2 V +1 CR +1 03/26/14, 16:38

  3. Wouter Wolters voted on patch set 2 CR +1 03/26/14, 16:42

  4. Mr. Jenkins commented on patch set 1 03/26/14, 16:46

  5. Mr. Jenkins commented on patch set 2 03/26/14, 16:47

  6. Frans Saris commented on patch set 2 03/26/14, 17:33

    Did anyone test this with storage set to non public (eIDFileDump)?
  7. Marc Bastian Heinrichs commented on patch set 2 CR +1 03/26/14, 17:59

    Frans, this should be another story, because only the conf is changed and given to rendering in $this->cObj->IMAGE(). So this have to be handled there.
  8. Frans Saris commented on patch set 2 V +1 CR +1 03/27/14, 13:41

    Was just curious. Should indeed not be part of this patch. But had a look at it and looks like it isn't an issue.
  9. Frans Saris voted on patch set 2 V +2 CR +2 03/27/14, 13:44

  10. Frans Saris merged patch set 3 03/27/14, 13:44