28856[BUGFIX] CSC: file references not working with image compression
Commit message
Review
-
Code review CR +2
- Frans Saris +2
- Wouter Wolters +1
- Tom +1
- Marc Bastian Heinrichs +1
-
Verified V +2
- Frans Saris +2
- Tom +1
Issues 1
Files 1
Review log 10
-
Benni Mack uploaded patch set 2 03/26/14, 16:32
-
Tom voted on patch set 2 V +1 CR +1 03/26/14, 16:38
-
Wouter Wolters voted on patch set 2 CR +1 03/26/14, 16:42
-
Mr. Jenkins commented on patch set 1 03/26/14, 16:46
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15757/ : SUCCESS -
Mr. Jenkins commented on patch set 2 03/26/14, 16:47
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15758/ : SUCCESS -
Frans Saris commented on patch set 2 03/26/14, 17:33
Did anyone test this with storage set to non public (eIDFileDump)? -
Marc Bastian Heinrichs commented on patch set 2 CR +1 03/26/14, 17:59
Frans, this should be another story, because only the conf is changed and given to rendering in $this->cObj->IMAGE(). So this have to be handled there. -
Frans Saris commented on patch set 2 V +1 CR +1 03/27/14, 13:41
Was just curious. Should indeed not be part of this patch. But had a look at it and looks like it isn't an issue. -
Frans Saris voted on patch set 2 V +2 CR +2 03/27/14, 13:44
-
Frans Saris merged patch set 3 03/27/14, 13:44