Review main Merged

28883[BUGFIX] Extension update fails if needed by other extensions

Nicole Hummel CR +2 V +2 Easy +0 −17 updated 03/29/14, 09:33

Commit message

On update process the extension which should be updated gets
uninstalled. This doesn't work if the extension is needed by other ones.
This patch removes the unload process before the update to make sure
system is working in the mean time.

Review

  • Code review CR +2
    • Markus Klein +2
    • Cedric Ziel +1
  • Verified V +2
    • Markus Klein +2
    • Cedric Ziel +1

Issues 1

Files 1

Review log 15

  1. Mr. Jenkins commented on patch set 1 03/26/14, 20:30

  2. Frans Saris commented on patch set 1 CR +1 03/27/14, 08:35

    Does anyone know why the uninstall was introduced?
  3. Philipp Gampe commented on patch set 1 03/27/14, 15:34

    Most like it had something to do with the cache.
  4. Nicole Hummel commented on patch set 1 03/27/14, 16:08

    But caches are cleared after installation anyway (debugged that!)
  5. Frans Saris commented on patch set 1 03/27/14, 16:29

    DB updates are also done?
  6. Nicole Hummel commented on patch set 1 03/27/14, 22:10

    It is the same procedure except the unload part. So yes, the DB gets updated as well.
  7. Cedric Ziel commented on patch set 1 V +1 CR +1 03/28/14, 18:11

    Smooth as butter again. Thank you Nicole.
  8. Markus Klein voted on patch set 1 CR +1 03/28/14, 18:36

  9. Stefan Neufeind commented on patch set 1 CR +1 03/28/14, 22:15

    Fine by reading. I expect it can also be installed while the extension is already running, so that we can really skip the unload.
    need => needed?
  10. Markus Klein updated the commit message in patch set 1 03/28/14, 22:54

  11. Markus Klein commented on patch set 2 CR +1 03/28/14, 22:54

    Just updated commit message
  12. Mr. Jenkins commented on patch set 2 03/28/14, 23:07

  13. Cedric Ziel voted on patch set 2 V +1 CR +1 03/29/14, 08:43

  14. Markus Klein voted on patch set 2 V +2 CR +2 03/29/14, 09:33

  15. Markus Klein merged patch set 3 03/29/14, 09:33