Review main Abandoned

28901[BUGFIX] Remove & for object passed to function

Markus Klein CR 0 V 0 Easy +2 −2 updated 06/19/14, 14:46

Commit message

Remove the pass-by-reference operator for object passed
to function in hook.
That does not work since the hook is called with $this,
which can't be passed by reference.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 18

  1. Mr. Jenkins commented on patch set 1 CR -1 V -1 03/27/14, 10:46

  2. Markus Klein updated the commit message in patch set 1 03/27/14, 11:27

  3. Mr. Jenkins commented on patch set 2 03/27/14, 11:41

  4. Oliver Klee voted on patch set 2 CR +1 03/27/14, 14:54

  5. Stefan Neufeind voted on patch set 2 CR +1 03/28/14, 22:51

  6. Stefan Neufeind commented on patch set 2 V -1 04/01/14, 19:43

    This is an API-change, as also discussed with Ernesto. If an extension uses the existing interface an error occurs. With or without the patch (if both occurences are patched) it works for me so far. I expect you received a warning in some strict-mode or so?
  7. Markus Klein commented on patch set 2 04/01/14, 20:14

    Stumbled over this by reading. We could move that to 6.3 or 7.0 no problem.
  8. Markus Klein updated the commit message in patch set 2 06/17/14, 18:03

  9. Markus Klein updated the commit message in patch set 3 06/17/14, 18:03

  10. Mr. Jenkins commented on patch set 3 06/17/14, 18:18

  11. Mr. Jenkins commented on patch set 4 06/17/14, 18:32

  12. Christian Kuhn voted on patch set 4 CR +1 06/17/14, 23:24

  13. Stefan Neufeind commented on patch set 4 06/18/14, 06:39

    But then how does somebody implementing that interface workaround the problem of a changed interface? What is the "migration-path" or how does he/she keep it running with before-6.3 and 6.3 then?
  14. Markus Klein commented on patch set 4 06/18/14, 08:29

    Hm... We should introduce a new interface then and deprecate the old one?
  15. Christian Kuhn voted on patch set 4 V +1 06/19/14, 14:30

  16. Christian Kuhn voted on patch set 4 V 0 CR 0 06/19/14, 14:32

  17. Christian Kuhn commented on patch set 4 CR -1 06/19/14, 14:40

    Ok, technically the & is obsolete, so much is clear. OTOH, changing this interface is breaking and leads to a FATAL for upgraders. AFAIK, this ampersand only throws a strict (?) warning, which is suppressed anyway. Imho, we should keep this unclean thing until we have real issues with it link warning level warnings in maybe upcoming PHP versions, since there is no urgent need to fix this currently by introducing a breaking change.
  18. Markus Klein abandoned the change 06/19/14, 14:46

    I agree that this is not necessary now. Will shut this down, such that it does not spam my dashboard.