Review main Merged

28909[BUGFIX] Respect config.debug setting for displaying parsetime

Georg Ringer CR +2 V +2 Easy +7 −1 updated 03/30/14, 15:45

Commit message

2 possible information snippets can be outputted using
config.debug = 1 in TypoScript or [FE][debug]=1 in Install Tool.

- Parsetime
- Cached page generated time + expire date

TypoScript should override the general setting of the Install Tool
to make it possible to turn debugging of for specific PAGE objects.

This is especially needed if using e.g JSON output is invalid
having this information.

The change uses the same check as in index_ts where it works perfectly
fine.

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Helmut Hummel +1
  • Verified V +2
    • Stefan Neufeind +2

Issues 1

Files 1

Review log 11

  1. Markus Klein commented on patch set 1 03/27/14, 12:33

  2. Mr. Jenkins commented on patch set 1 03/27/14, 12:38

  3. Andreas Allacher commented on patch set 1 V +1 03/27/14, 12:39

    I verified that the change works but maybe we should put the corresponding check in a Utility class ? So that it can be used on both places. @Markus: Actually the commit message already says that it was used there. [QUOTE] The change uses the same check as in index_ts where it works perfectly fine. [/QUOTE]
  4. Georg Ringer uploaded patch set 2 03/27/14, 12:43

  5. Mr. Jenkins commented on patch set 2 03/27/14, 12:57

  6. Helmut Hummel commented on patch set 2 CR +1 03/27/14, 13:37

    No Utility Class for this one, please ;)
  7. Andreas Allacher commented on patch set 2 03/27/14, 14:10

    We could still create a method in TSFE directly.
  8. Stefan Neufeind commented on patch set 2 CR -1 03/28/14, 22:48

    Isn't this what https://review.typo3.org/28663 aimed to fix (is meanwhile merged)? Or do we still have something unfixed?
  9. Georg Ringer commented on patch set 2 03/29/14, 13:08

    stfan: it is the same method but a different debug statement. just use debug = 1 and call a cached page the 2nd time and you will get it.
  10. Stefan Neufeind commented on patch set 2 V +2 CR +2 03/30/14, 15:45

    Thanks for the hint. Verified. Yes, this one is easy and quite similar to what was already merged.
  11. Stefan Neufeind merged patch set 3 03/30/14, 15:45