28909[BUGFIX] Respect config.debug setting for displaying parsetime
Commit message
Review
-
Code review CR +2
- Stefan Neufeind +2
- Helmut Hummel +1
-
Verified V +2
- Stefan Neufeind +2
Issues 1
Files 1
Review log 11
-
Markus Klein commented on patch set 1 03/27/14, 12:33
looks like a copy of https://review.typo3.org/#/c/28663/6/typo3/sysext/cms/tslib/index_ts.php -
Mr. Jenkins commented on patch set 1 03/27/14, 12:38
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15777/ : SUCCESS -
Andreas Allacher commented on patch set 1 V +1 03/27/14, 12:39
I verified that the change works but maybe we should put the corresponding check in a Utility class ? So that it can be used on both places. @Markus: Actually the commit message already says that it was used there. [QUOTE] The change uses the same check as in index_ts where it works perfectly fine. [/QUOTE] -
Georg Ringer uploaded patch set 2 03/27/14, 12:43
-
Mr. Jenkins commented on patch set 2 03/27/14, 12:57
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15778/ : SUCCESS -
Helmut Hummel commented on patch set 2 CR +1 03/27/14, 13:37
No Utility Class for this one, please ;) -
Andreas Allacher commented on patch set 2 03/27/14, 14:10
We could still create a method in TSFE directly. -
Stefan Neufeind commented on patch set 2 CR -1 03/28/14, 22:48
Isn't this what https://review.typo3.org/28663 aimed to fix (is meanwhile merged)? Or do we still have something unfixed? -
Georg Ringer commented on patch set 2 03/29/14, 13:08
stfan: it is the same method but a different debug statement. just use debug = 1 and call a cached page the 2nd time and you will get it. -
Stefan Neufeind commented on patch set 2 V +2 CR +2 03/30/14, 15:45
Thanks for the hint. Verified. Yes, this one is easy and quite similar to what was already merged. -
Stefan Neufeind merged patch set 3 03/30/14, 15:45