28926[BUGFIX] Sets defaultMailFromAddress as sender for install tool e-mails
Commit message
Review
-
Code review CR +2
- Markus Klein +2
- Stefan Neufeind +1
- Oliver Klee +1
- Wouter Wolters +1
-
Verified V +2
- Markus Klein +2
- Wouter Wolters +1
Issues 1
Files 3
Review log 33
Show 8 earlier messages
-
Mr. Jenkins commented on patch set 1 CR -1 V -1 03/28/14, 08:10
Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/15786/ : FAILURE -
Markus Klein updated the commit message in patch set 1 03/28/14, 08:20
-
Markus Klein voted on patch set 2 V +1 CR +1 03/28/14, 08:22
-
Torben Hansen uploaded patch set 3 03/28/14, 08:23
-
Mr. Jenkins commented on patch set 2 03/28/14, 08:35
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15787/ : SUCCESS -
Mr. Jenkins commented on patch set 3 03/28/14, 08:37
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15788/ : SUCCESS -
Stefan Neufeind commented on patch set 3 03/28/14, 22:38
I tried *without* this patch and was astonished to see I received emails from "no-reply@example.com". THat address seems to be set in MailUtility if "everything else" fails. So does ...@example.org maybe not pass the validEmail()-check or so? Since "no-reply@example.com" is already in MailUtility, shouldn't we use *one* default for all cases? Can we just skip the addFrom() if no good value is set and get the default-address used then? -
Markus Klein commented on patch set 3 03/28/14, 22:50
That's indeed a good point Stefan. We should change that.
-
Torben Hansen uploaded patch set 4 03/29/14, 12:34
-
Torben Hansen commented on patch set 4 03/29/14, 12:36
I could not figure out to get the install tool sending me e-mails from no-reply@example.com, when logging into install tool. I tried with and without a [MAIL][defaultMailFromAddress] but the sender was always typo3installtool@example.org. I also tried to use \TYPO3\CMS\Core\Utility\MailUtility::getSystemFrom() to get a sender address (this is the only place in TYPO3, where no-reply@example.com seems to be used), but this fails, as getSystemFrom() uses $GLOBALS['TYPO3_DB'], which not seems to be initialized at this time. I also tried to remove addFrom() which results in no e-mail being sent at all. I modified to patch so it adds no-reply@example.com as a sender, if [MAIL][defaultMailFromAddress] is not set. I think, TYPO3 install tool should least use [MAIL][defaultMailFromAddress] as sender, if configured. -
Mr. Jenkins commented on patch set 4 03/29/14, 12:47
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15806/ : SUCCESS -
Stefan Neufeind commented on patch set 4 04/05/14, 13:30
Didn't find time to test this again. Markus, can you maybe reproduce this as well? -
Markus Klein voted on patch set 4 CR +1 04/16/14, 23:01
-
Wouter Wolters voted on patch set 4 CR +1 04/22/14, 21:19
-
Oliver Klee commented on patch set 4 04/23/14, 07:32
AbstractController.php:322This is duplicate code, and also a hardcoded e-mail address in the middle of the code. Let's move this to a separate method (e.g. getDefaultMailFronAddress) and move the no-reply@example.com address to a class constant. -
Markus Klein uploaded patch set 5 04/23/14, 09:31
-
Markus Klein voted on patch set 5 CR +1 04/23/14, 09:35
-
Mr. Jenkins commented on patch set 5 04/23/14, 09:44
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16095/ : SUCCESS -
Torben Hansen voted on patch set 5 CR +1 04/23/14, 10:26
-
Oliver Klee voted on patch set 5 CR +1 04/23/14, 13:02
-
Markus Klein voted on patch set 5 V +1 04/24/14, 22:41
-
Wouter Wolters commented on patch set 5 04/29/14, 18:46
TestSetup can also send a test e-mail. Should we also implement this getter there? -
Markus Klein commented on patch set 5 04/29/14, 21:21
Sounds good Wouter. Can you do that? -
Stefan Neufeind commented on patch set 5 CR -1 04/29/14, 22:06
Waiting for addition from Wouter ... (Thanks in advance.) -
Wouter Wolters uploaded patch set 6 04/30/14, 17:47
-
Oliver Klee voted on patch set 6 CR +1 04/30/14, 17:48
-
Wouter Wolters commented on patch set 6 V +1 CR +1 04/30/14, 17:50
Only copied and pasted the same code in the TestSeup code and passed the address to the view to use it in Fluid template where the e-mailaddress was also displayed -
Mr. Jenkins commented on patch set 6 04/30/14, 18:13
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16180/ : SUCCESS https://ci.typo3.org/job/typo3-v4-core-gerrit/16176/ : SUCCESS -
Stefan Neufeind voted on patch set 6 CR +1 04/30/14, 19:05
-
Markus Klein voted on patch set 6 V +2 CR +2 04/30/14, 21:10
-
Markus Klein merged patch set 7 04/30/14, 21:10
-
Andreas Kienast voted on patch set 2 CR +1 09/05/18, 18:49
-
Andreas Kienast voted on patch set 3 CR +1 09/05/18, 18:49