Review main Merged

28926[BUGFIX] Sets defaultMailFromAddress as sender for install tool e-mails

Torben Hansen CR +2 V +2 Easy +31 −5 updated 09/05/18, 18:49

Commit message

This patch sets [MAIL][defaultMailFromAddress] as a sender for successful
and failed login mails for the install tool. If no defaultMailFromAddress
is set, the fallback sender address is set to no-reply@example.com

Review

  • Code review CR +2
    • Markus Klein +2
    • Stefan Neufeind +1
    • Oliver Klee +1
    • Wouter Wolters +1
  • Verified V +2
    • Markus Klein +2
    • Wouter Wolters +1

Issues 1

Files 3

Review log 33

Show 8 earlier messages
  1. Mr. Jenkins commented on patch set 1 CR -1 V -1 03/28/14, 08:10

  2. Markus Klein updated the commit message in patch set 1 03/28/14, 08:20

  3. Markus Klein voted on patch set 2 V +1 CR +1 03/28/14, 08:22

  4. Torben Hansen uploaded patch set 3 03/28/14, 08:23

  5. Mr. Jenkins commented on patch set 2 03/28/14, 08:35

  6. Mr. Jenkins commented on patch set 3 03/28/14, 08:37

  7. Stefan Neufeind commented on patch set 3 03/28/14, 22:38

    I tried *without* this patch and was astonished to see I received emails from "no-reply@example.com". THat address seems to be set in MailUtility if "everything else" fails. So does ...@example.org maybe not pass the validEmail()-check or so? Since "no-reply@example.com" is already in MailUtility, shouldn't we use *one* default for all cases? Can we just skip the addFrom() if no good value is set and get the default-address used then?
  8. Markus Klein commented on patch set 3 03/28/14, 22:50

    That's indeed a good point Stefan. We should change that.
  1. Torben Hansen uploaded patch set 4 03/29/14, 12:34

  2. Torben Hansen commented on patch set 4 03/29/14, 12:36

    I could not figure out to get the install tool sending me e-mails from no-reply@example.com, when logging into install tool. I tried with and without a [MAIL][defaultMailFromAddress] but the sender was always typo3installtool@example.org. I also tried to use \TYPO3\CMS\Core\Utility\MailUtility::getSystemFrom() to get a sender address (this is the only place in TYPO3, where no-reply@example.com seems to be used), but this fails, as getSystemFrom() uses $GLOBALS['TYPO3_DB'], which not seems to be initialized at this time. I also tried to remove addFrom() which results in no e-mail being sent at all. I modified to patch so it adds no-reply@example.com as a sender, if [MAIL][defaultMailFromAddress] is not set. I think, TYPO3 install tool should least use [MAIL][defaultMailFromAddress] as sender, if configured.
  3. Mr. Jenkins commented on patch set 4 03/29/14, 12:47

  4. Stefan Neufeind commented on patch set 4 04/05/14, 13:30

    Didn't find time to test this again. Markus, can you maybe reproduce this as well?
  5. Markus Klein voted on patch set 4 CR +1 04/16/14, 23:01

  6. Wouter Wolters voted on patch set 4 CR +1 04/22/14, 21:19

  7. Oliver Klee commented on patch set 4 04/23/14, 07:32

    AbstractController.php:322

    This is duplicate code, and also a hardcoded e-mail address in the middle of the code. Let's move this to a separate method (e.g. getDefaultMailFronAddress) and move the no-reply@example.com address to a class constant.
  8. Markus Klein uploaded patch set 5 04/23/14, 09:31

  9. Markus Klein voted on patch set 5 CR +1 04/23/14, 09:35

  10. Mr. Jenkins commented on patch set 5 04/23/14, 09:44

  11. Torben Hansen voted on patch set 5 CR +1 04/23/14, 10:26

  12. Oliver Klee voted on patch set 5 CR +1 04/23/14, 13:02

  13. Markus Klein voted on patch set 5 V +1 04/24/14, 22:41

  14. Wouter Wolters commented on patch set 5 04/29/14, 18:46

    TestSetup can also send a test e-mail. Should we also implement this getter there?
  15. Markus Klein commented on patch set 5 04/29/14, 21:21

    Sounds good Wouter. Can you do that?
  16. Stefan Neufeind commented on patch set 5 CR -1 04/29/14, 22:06

    Waiting for addition from Wouter ... (Thanks in advance.)
  17. Wouter Wolters uploaded patch set 6 04/30/14, 17:47

  18. Oliver Klee voted on patch set 6 CR +1 04/30/14, 17:48

  19. Wouter Wolters commented on patch set 6 V +1 CR +1 04/30/14, 17:50

    Only copied and pasted the same code in the TestSeup code and passed the address to the view to use it in Fluid template where the e-mailaddress was also displayed
  20. Mr. Jenkins commented on patch set 6 04/30/14, 18:13

  21. Stefan Neufeind voted on patch set 6 CR +1 04/30/14, 19:05

  22. Markus Klein voted on patch set 6 V +2 CR +2 04/30/14, 21:10

  23. Markus Klein merged patch set 7 04/30/14, 21:10

  24. Andreas Kienast voted on patch set 2 CR +1 09/05/18, 18:49

  25. Andreas Kienast voted on patch set 3 CR +1 09/05/18, 18:49