28976[TASK] Trigger events in DragUploader
Commit message
Review
-
Code review CR +2
- Xavier Perseguers +2
- Stefan Neufeind +1
- Wouter Wolters +1
- Frans Saris +1
- Helmut Hummel +1
-
Verified V +2
- Xavier Perseguers +2
- Stefan Neufeind +1
- Frans Saris +1
Issues 1
Files 1
Review log 17
-
Georg Ringer updated the commit message in patch set 1 03/31/14, 13:09
-
Mr. Jenkins commented on patch set 1 03/31/14, 13:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15811/ : SUCCESS -
Mr. Jenkins commented on patch set 2 03/31/14, 13:23
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15812/ : SUCCESS -
Marc Bastian Heinrichs updated the commit message in patch set 2 03/31/14, 13:33
-
Mr. Jenkins commented on patch set 3 03/31/14, 13:46
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15813/ : SUCCESS -
Nicole Hummel commented on patch set 3 04/04/14, 08:54
@steffen: i love the idea. could you say your opinion about that, then i would test the functions -
Stefan Neufeind voted on patch set 3 CR +1 04/04/14, 15:15
-
Frans Saris voted on patch set 3 CR +1 04/10/14, 19:22
-
Helmut Hummel voted on patch set 3 CR +1 04/15/14, 22:05
-
Stefan Neufeind commented on patch set 3 V +1 04/16/14, 03:18
Tried with the code from forge-issue. It actually does trigger and adds some button (without judging about the button itself or so). So the trigger seems to work fine. -
Xavier Perseguers voted on patch set 3 CR +1 04/22/14, 07:28
-
Wouter Wolters voted on patch set 3 CR +1 04/22/14, 20:03
-
Frans Saris commented on patch set 3 V +1 CR -1 06/05/14, 21:16
Tested the new triggered events and this works. But I'm wondering why the extra $trigger parameter is added, why not trigger is on the .dragUploader itself?DragUploader.js:212Why the extra $trigger parameter? -
Xavier Perseguers commented on patch set 3 06/12/14, 12:09
DragUploader.js:212ReplyThis extra parameter relates to this definition in DragUploader class: me.$trigger = $(me.$element.data('dropzone-trigger')); -
Frans Saris commented on patch set 3 CR +1 06/12/14, 12:22
DragUploader.js:212ReplyYou are right! My own work :D -
Xavier Perseguers voted on patch set 3 V +2 CR +2 06/12/14, 12:26
-
Xavier Perseguers merged patch set 4 06/12/14, 12:26