29004*WIP* [FEATURE] Extbase entities for core tables
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 10
- typo3/sysext/core/Configuration/TCA/pages.php+33 −2
- typo3/sysext/core/ext_tables.sql+2 −0
- typo3/sysext/extbase/Classes/Domain/Model/BackendLayout.php2new+85 −0
- typo3/sysext/extbase/Classes/Domain/Model/ContentElement.php2new+130 −0
- typo3/sysext/extbase/Classes/Domain/Model/Page.php1new+279 −0
- typo3/sysext/extbase/Classes/Domain/Model/SystemLanguage.php4new+93 −0
- typo3/sysext/extbase/Classes/Domain/Repository/ContentElementRepository.phpnew+33 −0
- typo3/sysext/extbase/Classes/Domain/Repository/PageRepository.phpnew+44 −0
- typo3/sysext/extbase/Classes/Domain/Repository/SystemLanguageRepository.phpnew+40 −0
- typo3/sysext/extbase/ext_typoscript_setup.txt2+47 −19
Review log 8
-
Mr. Jenkins commented on patch set 1 03/31/14, 21:56
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15825/ : SUCCESS -
Mathias Brodala commented on patch set 1 04/03/14, 15:40
No score for now due to WIP but a few comments.BackendLayout.php:45How about $configuration?Page.php:38See comment for ext_typoscript_setup.txt: this could simply be $type.SystemLanguage.php:44How about $flagIconName?SystemLanguage.php:49How about $isoCode? The original field name implies some relation to static_info_tables which does not exist.ext_typoscript_setup.txt:79What are these two (apparently equal) mappings good for?ext_typoscript_setup.txt:110How about simply mapping it to "type"? -
Stefan Neufeind commented on patch set 1 04/04/14, 15:19
BackendLayout.php:45Reply+1. We have $configuration in other places and usually try to use "long" names meanwhile.ContentElement.php:77whitespacesContentElement.php:103we currently only use "string" afaik, since it's not a real data-/object-type in php anyway -
Oliver Klee commented on patch set 1 04/05/14, 12:06
SystemLanguage.php:34Why not just "Language" instead of "SystemLanguage"? -
Stefan Neufeind commented on patch set 1 04/05/14, 13:25
SystemLanguage.php:34ReplyComes from sys_language. But a valid point here imho. We also just have "file" instead of translating the "sys_file" with System as well. -
Christian Kuhn commented on patch set 1 CR -2 04/05/14, 20:19
-2, Do not submit for now to prevent merging before master branch is open again. Please trigger me if i forget about this vote later! -
Felix Kopp commented on patch set 1 06/19/14, 15:17
6.3? -
Felix Kopp abandoned the change 08/11/14, 16:03
I will not work on this anymore. Feel free to take over.