Review main Abandoned

29004*WIP* [FEATURE] Extbase entities for core tables

Felix Kopp CR 0 V 0 Hard +786 −21 updated 08/11/14, 16:03

Commit message

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 10

Review log 8

  1. Mr. Jenkins commented on patch set 1 03/31/14, 21:56

  2. Mathias Brodala commented on patch set 1 04/03/14, 15:40

    No score for now due to WIP but a few comments.

    BackendLayout.php:45

    How about $configuration?

    Page.php:38

    See comment for ext_typoscript_setup.txt: this could simply be $type.

    SystemLanguage.php:44

    How about $flagIconName?

    SystemLanguage.php:49

    How about $isoCode? The original field name implies some relation to static_info_tables which does not exist.

    ext_typoscript_setup.txt:79

    What are these two (apparently equal) mappings good for?

    ext_typoscript_setup.txt:110

    How about simply mapping it to "type"?
  3. Stefan Neufeind commented on patch set 1 04/04/14, 15:19

    BackendLayout.php:45 Reply

    +1. We have $configuration in other places and usually try to use "long" names meanwhile.

    ContentElement.php:77

    whitespaces

    ContentElement.php:103

    we currently only use "string" afaik, since it's not a real data-/object-type in php anyway
  4. Oliver Klee commented on patch set 1 04/05/14, 12:06

    SystemLanguage.php:34

    Why not just "Language" instead of "SystemLanguage"?
  5. Stefan Neufeind commented on patch set 1 04/05/14, 13:25

    SystemLanguage.php:34 Reply

    Comes from sys_language. But a valid point here imho. We also just have "file" instead of translating the "sys_file" with System as well.
  6. Christian Kuhn commented on patch set 1 CR -2 04/05/14, 20:19

    -2, Do not submit for now to prevent merging before master branch is open again. Please trigger me if i forget about this vote later!
  7. Felix Kopp commented on patch set 1 06/19/14, 15:17

    6.3?
  8. Felix Kopp abandoned the change 08/11/14, 16:03

    I will not work on this anymore. Feel free to take over.