Review main Merged

29054[BUGFIX] Add l18n_parent to tt_content TCA

Alexander Bigga CR +2 V +2 Easy +1 −1 updated 05/03/14, 09:15

Commit message

If an editor ignores the "Copy default content elements"-button, it is
not possible to get a new content element in the alternative language
related to it's parent.

The existing l18n_parent field is never shown. This seems to be a bug
which was introduced in TYPO3 4.5 and exists up to now.

The patch adds the l18n_parent field to the general tab.

Review

  • Code review CR +2
    • Oliver Hader +2
    • Anja Leichsenring +1
    • Nadir S. +1
    • Christian Kuhn +1
    • Frans Saris +1
    • Sascha Wilking +1
  • Verified V +2
    • Oliver Hader +2
    • Anja Leichsenring +1
    • Nadir S. +1
    • Christian Kuhn +1
    • Sascha Wilking +1

Issues 1

Files 1

Review log 8

  1. Mr. Jenkins commented on patch set 1 04/01/14, 21:21

  2. Frans Saris voted on patch set 1 CR +1 04/22/14, 09:23

  3. Nadir S. voted on patch set 1 V +1 CR +1 05/02/14, 17:02

  4. Sascha Wilking voted on patch set 1 V +1 CR +1 05/02/14, 19:28

  5. Christian Kuhn commented on patch set 1 V +1 CR +1 05/03/14, 08:02

    seems fine. verified that in 4.6 this was also set in a "general" header part of tt_content. Will have a small chat with Olly and merge then.
  6. Anja Leichsenring voted on patch set 1 V +1 CR +1 05/03/14, 08:11

  7. Oliver Hader commented on patch set 1 V +2 CR +2 05/03/14, 09:14

    Code-wise the change looks good, however, there are some side-effects in general that are to related to tt_content and the default fallback labels. Since these effects are not caused by this change, it's fine see issue #58444 that describes those side-effects
  8. Oliver Hader merged patch set 2 05/03/14, 09:15