29054[BUGFIX] Add l18n_parent to tt_content TCA
Commit message
Review
-
Code review CR +2
- Oliver Hader +2
- Anja Leichsenring +1
- Nadir S. +1
- Christian Kuhn +1
- Frans Saris +1
- Sascha Wilking +1
-
Verified V +2
- Oliver Hader +2
- Anja Leichsenring +1
- Nadir S. +1
- Christian Kuhn +1
- Sascha Wilking +1
Issues 1
Files 1
Review log 8
-
Mr. Jenkins commented on patch set 1 04/01/14, 21:21
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15849/ : SUCCESS -
Frans Saris voted on patch set 1 CR +1 04/22/14, 09:23
-
Nadir S. voted on patch set 1 V +1 CR +1 05/02/14, 17:02
-
Sascha Wilking voted on patch set 1 V +1 CR +1 05/02/14, 19:28
-
Christian Kuhn commented on patch set 1 V +1 CR +1 05/03/14, 08:02
seems fine. verified that in 4.6 this was also set in a "general" header part of tt_content. Will have a small chat with Olly and merge then. -
Anja Leichsenring voted on patch set 1 V +1 CR +1 05/03/14, 08:11
-
Oliver Hader commented on patch set 1 V +2 CR +2 05/03/14, 09:14
Code-wise the change looks good, however, there are some side-effects in general that are to related to tt_content and the default fallback labels. Since these effects are not caused by this change, it's fine see issue #58444 that describes those side-effects -
Oliver Hader merged patch set 2 05/03/14, 09:15