29095[BUGFIX] Improve the admin panel
Commit message
Review
-
Code review CR +2
- Stefan Neufeind +2
- Markus Klein +1
-
Verified V +2
- Stefan Neufeind +2
- Markus Klein +1
Issues 1
Files 2
Review log 36
Show 11 earlier messages
-
Mr. Jenkins commented on patch set 1 04/02/14, 17:42
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15861/ : SUCCESS -
Markus Klein voted on patch set 1 V +1 CR +1 04/02/14, 18:11
-
Stefan Neufeind commented on patch set 1 V +1 CR -1 04/04/14, 11:38
works. will push an extended version soon though -
Stefan Neufeind uploaded patch set 2 04/04/14, 12:03
-
Stefan Neufeind commented on patch set 2 V +1 CR +1 04/04/14, 12:14
Added cleanups for htmlspecialchars. Stumbled across a "Web>List" during review of this patch in the icons. If getSpriteIcon is called with a title, the title must not be specialchared before. -
Mr. Jenkins commented on patch set 2 04/04/14, 12:17
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15889/ : SUCCESS -
Markus Klein voted on patch set 2 CR +1 04/11/14, 23:41
-
Oliver Klee commented on patch set 2 04/12/14, 07:23
AdminPanelView.php:614Why remove these calls to htmlspecialchars? AFAICS, this would also leave the ampersands unencoded. -
Stefan Neufeind commented on patch set 2 V -1 CR -1 04/12/14, 08:40
AdminPanelView.php:614ReplyYou are right. It's those in extGetLL that need to go -
Stefan Neufeind uploaded patch set 3 04/12/14, 08:46
-
Mr. Jenkins commented on patch set 3 04/12/14, 08:59
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15943/ : SUCCESS
-
Markus Klein commented on patch set 3 V -1 CR -1 04/12/14, 09:33
1) you reintroduced the bug that should have been fixed 2) Georg is still the author of the main changes So please go back to set 1 and change the hsc stuff there.AdminPanelView.php:598wrong again now: edit_recordHistory -
Stefan Neufeind uploaded patch set 5 04/12/14, 23:19
-
Stefan Neufeind commented on patch set 5 04/12/14, 23:24
Of course Georg is the main author. That slipped through when I worked locally with a patch-file, applied changes to the code and pushed it again without explicitly giving the author again. Went back to patchset 1 and just redid the htmlspecialchars()-things. Please check. -
Markus Klein commented on patch set 5 V +1 CR +1 04/12/14, 23:37
AdminPanelView.php:657Just one idea. Should we introduce a second param telling the function whether it should hsc or not? currently he have 21 usuage where we need to add hsc(), but only 7 usages, where we don't need the hsc(). So if we add the param here, we only need to add 7 FALSE. -
Mr. Jenkins commented on patch set 5 04/12/14, 23:38
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15976/ : SUCCESS -
Stefan Neufeind commented on patch set 5 04/13/14, 01:06
AdminPanelView.php:657ReplyThought about that as well. But then it would be more than just a "wrapper" for accessing the object from globals. And what would we call it to make sure that it (optionally!) allows hsc or even has hsc by default?!? -
Markus Klein commented on patch set 5 04/13/14, 01:11
extGetLL($a, $hsc = TRUE) { $val = ...; if ($hsc) $val = hsc($val); return $val } so we only need to add the FALSE as second param to the 7 places -
Stefan Neufeind uploaded patch set 6 04/13/14, 08:58
-
Stefan Neufeind commented on patch set 6 04/13/14, 09:00
I don't really like that solution, since the name extGetLL imho says that the getLL-function is encapsulated and now we add a functionality that does not really belong into fetching a lable. Also we add a default-behaviour (TRUE) that I would not expect from a function for fetching labels. But I'll do as you please ... -
Markus Klein commented on patch set 6 04/13/14, 09:02
Looks great nowAdminPanelView.php:654two nitpicks: boolean -> bool lable -> label -
Stefan Neufeind uploaded patch set 7 04/13/14, 09:09
-
Markus Klein commented on patch set 6 04/13/14, 09:09
First, this was only a suggestion. No need to implement it. (I began my suggestion with the words "Just an idea:") Second, I don't see this as a plain wrapper, since it had the hsc before. So the default behavior does not even change. As I said, that was just an idea and I'm fine with either solution. -
Stefan Neufeind commented on patch set 7 04/13/14, 09:09
It is "boolean" all over the place in that file. But okay ... -
Markus Klein voted on patch set 7 V +1 CR +1 04/13/14, 09:10
-
Mr. Jenkins commented on patch set 6 04/13/14, 09:12
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15979/ : SUCCESS -
Oliver Klee commented on patch set 7 04/13/14, 09:18
That's because at some point we (the people at some ACME, IIRC) decided to use "bool" and "int" from that point on. :-) -
Mr. Jenkins commented on patch set 7 04/13/14, 09:22
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15980/ : SUCCESS -
Stefan Neufeind commented on patch set 7 04/13/14, 09:33
AdminPanelView.php:657let's make this "protected" before commit. It never was intended to have this publically available -
Stefan Neufeind voted on patch set 7 CR +1 04/13/14, 10:08
-
Robert Vock commented on patch set 7 V +1 CR +1 04/14/14, 07:06
I checked out PatchSet 7 and tested it. Looks good to me -
Markus Klein uploaded patch set 8 04/14/14, 09:13
-
Markus Klein commented on patch set 8 V +1 CR +1 04/14/14, 09:15
Fixed the protected and some other small issues. Let's get this merged.AdminPanelView.php:594$this->pageinfo does NOT exist as member and is never set anywhere in this class. So this looks like another bug. -
Stefan Neufeind voted on patch set 8 V +2 CR +2 04/14/14, 09:15
-
Stefan Neufeind merged patch set 9 04/14/14, 09:15
-
Mr. Jenkins commented on patch set 8 04/14/14, 09:27
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15999/ : SUCCESS