29110[BUGFIX] Admin users should ignore user mounts
Commit message
Review
-
Code review CR +2
- Stefan Neufeind +2
- Dmitry Dulepov +2
-
Verified V +2
- Stefan Neufeind +2
- Dmitry Dulepov +2
Issues 1
Files 1
Review log 25
-
Pascal Dürsteler uploaded patch set 2 04/03/14, 08:20
-
Mr. Jenkins commented on patch set 1 04/03/14, 08:34
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15864/ : SUCCESS -
Mr. Jenkins commented on patch set 2 04/03/14, 08:35
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15865/ : SUCCESS -
Pascal Dürsteler commented on patch set 2 V -1 CR -1 04/03/14, 08:45
This currently breaks the group db mounts, which is not intended behavior. -
Pascal Dürsteler uploaded patch set 3 04/03/14, 08:58
-
Pascal Dürsteler uploaded patch set 4 04/03/14, 08:59
-
Mr. Jenkins commented on patch set 3 04/03/14, 09:13
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15866/ : SUCCESS -
Mr. Jenkins commented on patch set 4 04/03/14, 09:14
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15867/ : SUCCESS -
Stefan Neufeind commented on patch set 4 04/04/14, 15:22
How about file-mountpoints? -
Pascal Dürsteler commented on patch set 4 04/04/14, 15:38
Valid point, haven't considered those ones. Will do! -
Stefan Neufeind commented on patch set 4 CR -1 04/05/14, 18:43
awaiting new patch-version from Pascal -
Pascal Dürsteler uploaded patch set 5 04/07/14, 07:24
-
Stefan Neufeind commented on patch set 5 CR -1 04/07/14, 07:26
You don't really want to comment out the isAdmin() here, do you? ;-) -
Pascal Dürsteler commented on patch set 5 V -1 CR -1 04/07/14, 07:28
ugh, don't ask... -
Pascal Dürsteler uploaded patch set 6 04/07/14, 07:29
-
Mr. Jenkins commented on patch set 5 04/07/14, 07:39
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15905/ : SUCCESS -
Mr. Jenkins commented on patch set 6 04/07/14, 07:44
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15906/ : SUCCESS -
Stefan Neufeind commented on patch set 6 CR +1 04/07/14, 07:52
Looks like a viable solution to me. Didn't check yet what the mounts are initialised with if you don't set them here - but I'd expect them to be empty. I agree that having the full tree *and* additional mounts from below doesn't really make sense and just clutters the tree. -
Dmitry Dulepov commented on patch set 6 V +2 CR +2 04/09/14, 08:03
Reviewed and tested. -
Stefan Neufeind voted on patch set 6 V +2 CR +2 04/13/14, 10:13
-
Stefan Neufeind merged patch set 7 04/13/14, 10:13
-
Stefan Neufeind commented on patch set 7 04/24/14, 10:13
Running on 6.2.1 here, so the patch is already included. As admin I see the full tree - but also one tree (webmount) because of a group I'm member of. How can that be? Removing the group-membership gets rid of the second mount, adding it again brings it back :-( -
Pascal Dürsteler commented on patch set 7 04/25/14, 10:12
Because the group is not taken into account here. As you have a visible group field for admin records, the group mounts are being processed. Contrary to the "DB Mounts" field which you don't have as an admin, but as a "default" backend user. The intention is that you may want to have multiple mounts there if you got a big page tree or something. -
Marc Bastian Heinrichs commented on patch set 7 06/17/15, 09:26
You know this setting in a BE user? Mount from groups: X DB Mounts X File Mounts -
Helmut Hummel commented on patch set 7 08/14/15, 22:24
Reverted This patchset was reverted in change: Id687402901d6246c66bfca38b800a7947d099308