Review main Merged

29110[BUGFIX] Admin users should ignore user mounts

Pascal Dürsteler CR +2 V +2 Easy +8 −4 updated 08/14/15, 22:24

Commit message

Admin user records still process earlier defined mounts which leads
to a cluttered page tree or filelist tree, respectively.

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Dmitry Dulepov +2
  • Verified V +2
    • Stefan Neufeind +2
    • Dmitry Dulepov +2

Issues 1

Files 1

Review log 25

  1. Pascal Dürsteler uploaded patch set 2 04/03/14, 08:20

  2. Mr. Jenkins commented on patch set 1 04/03/14, 08:34

  3. Mr. Jenkins commented on patch set 2 04/03/14, 08:35

  4. Pascal Dürsteler commented on patch set 2 V -1 CR -1 04/03/14, 08:45

    This currently breaks the group db mounts, which is not intended behavior.
  5. Pascal Dürsteler uploaded patch set 3 04/03/14, 08:58

  6. Pascal Dürsteler uploaded patch set 4 04/03/14, 08:59

  7. Mr. Jenkins commented on patch set 3 04/03/14, 09:13

  8. Mr. Jenkins commented on patch set 4 04/03/14, 09:14

  9. Stefan Neufeind commented on patch set 4 04/04/14, 15:22

    How about file-mountpoints?
  10. Pascal Dürsteler commented on patch set 4 04/04/14, 15:38

    Valid point, haven't considered those ones. Will do!
  11. Stefan Neufeind commented on patch set 4 CR -1 04/05/14, 18:43

    awaiting new patch-version from Pascal
  12. Pascal Dürsteler uploaded patch set 5 04/07/14, 07:24

  13. Stefan Neufeind commented on patch set 5 CR -1 04/07/14, 07:26

    You don't really want to comment out the isAdmin() here, do you? ;-)
  14. Pascal Dürsteler commented on patch set 5 V -1 CR -1 04/07/14, 07:28

    ugh, don't ask...
  15. Pascal Dürsteler uploaded patch set 6 04/07/14, 07:29

  16. Mr. Jenkins commented on patch set 5 04/07/14, 07:39

  17. Mr. Jenkins commented on patch set 6 04/07/14, 07:44

  18. Stefan Neufeind commented on patch set 6 CR +1 04/07/14, 07:52

    Looks like a viable solution to me. Didn't check yet what the mounts are initialised with if you don't set them here - but I'd expect them to be empty. I agree that having the full tree *and* additional mounts from below doesn't really make sense and just clutters the tree.
  19. Dmitry Dulepov commented on patch set 6 V +2 CR +2 04/09/14, 08:03

    Reviewed and tested.
  20. Stefan Neufeind voted on patch set 6 V +2 CR +2 04/13/14, 10:13

  21. Stefan Neufeind merged patch set 7 04/13/14, 10:13

  22. Stefan Neufeind commented on patch set 7 04/24/14, 10:13

    Running on 6.2.1 here, so the patch is already included. As admin I see the full tree - but also one tree (webmount) because of a group I'm member of. How can that be? Removing the group-membership gets rid of the second mount, adding it again brings it back :-(
  23. Pascal Dürsteler commented on patch set 7 04/25/14, 10:12

    Because the group is not taken into account here. As you have a visible group field for admin records, the group mounts are being processed. Contrary to the "DB Mounts" field which you don't have as an admin, but as a "default" backend user. The intention is that you may want to have multiple mounts there if you got a big page tree or something.
  24. Marc Bastian Heinrichs commented on patch set 7 06/17/15, 09:26

    You know this setting in a BE user? Mount from groups: X DB Mounts X File Mounts
  25. Helmut Hummel commented on patch set 7 08/14/15, 22:24

    Reverted This patchset was reverted in change: Id687402901d6246c66bfca38b800a7947d099308