29167[BUGFIX] Adminpanel: Parts under "Editing" only with EXT:feedit
Commit message
Review
-
Code review CR +2
- Georg Ringer +2
- Josef Glatz +1
- Michael Oehlhof +1
- Oliver Eglseder +1
-
Verified V +2
- Georg Ringer +2
- Josef Glatz +1
- Oliver Eglseder +1
Issues 1
Files 1
Review log 43
Show 18 earlier messages
-
Mr. Jenkins commented on patch set 1 04/04/14, 13:43
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15890/ : SUCCESS -
Pascal Dürsteler voted on patch set 1 CR +1 04/04/14, 13:53
-
Nicole Hummel voted on patch set 1 CR +1 04/04/14, 13:59
-
Nicole Hummel commented on patch set 1 V +1 04/05/14, 22:10
I checked the code from feeditadvanced and aloha. This change doesn't seem to have any impact as they using own variables. -
Christian Kuhn commented on patch set 1 04/05/14, 22:32
mmmh, this introduces a connection from ext:frontend to ext:feedit. it would be cleaner if there would be a signal or a hook instead. -
Christian Kuhn commented on patch set 1 CR -1 04/05/14, 22:33
-1 for the above reason, but you can override this if not feasible. i'd be in favor of a loose coupling, though. -
Nicole Hummel commented on patch set 1 04/05/14, 22:34
@Christian: Stefan and I discussed that already and decided that this would be a feature. This patch is about removing an unsupported area to prevent confusion for users. -
Christian Kuhn commented on patch set 1 04/05/14, 22:45
hmmm, my opinion defers there regarding the "feature" view: Introducing isLoaded() in a ext:frontend (always loaded) to an optional core extension is really not nice. if we introduce a signal here and maybe move the feedit specific code to ext:feedit along the way, it is imho a "task" that maybe even gives us the additional feature that any other extension could use it if it wants to slot into the admin panel. I'd personally would be fine with doing that for 6.2, too, since it is a mixture of ux improvement and a better separation of concerns that only gives benefits if done without bugs. -
Christian Kuhn commented on patch set 1 04/05/14, 22:52
otoh, the current patch is a pretty simple solution, introducing signal/slot here will be more complex and risky and potentially more breaking. the decision is up to you since i do not really know how the "clean" version would look like, so i can not see its impact then ... unsure. i'll remove the -1 if you want, even with my objections. -
Stefan Neufeind commented on patch set 1 04/06/14, 03:51
@Christian: Clean solution would imho be not have "Editing" hardcoded here at all, but a hook/slot that extensions can use to extend the adminpanel. That would be way above this patch though. The other editing-solutions we found so far don't use this panel-part here. And it's not really a "dep" in terms of package-management - it's just an isLoaded(). The coupling "is there already" since adminpanel contains icons without functionality unless you use feedit. -
Nicole Hummel uploaded patch set 2 05/04/14, 22:11
-
Nicole Hummel commented on patch set 2 CR +1 05/04/14, 22:11
Rebase according to current master -
Mr. Jenkins commented on patch set 2 05/05/14, 04:46
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16312/ : SUCCESS https://ci.typo3.org/job/typo3-v4-core-gerrit/16308/ : SUCCESS -
Markus Klein voted on patch set 2 CR +1 05/05/14, 07:33
-
Soren Malling commented on patch set 2 05/05/14, 07:33
Would it rather be a check if the array is set, since EXT:feedit just registers itself in that way? $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['typo3/classes/class.frontendedit.php']['edit'] = 'TYPO3\\CMS\\Feedit\\FrontendEditPanel' -
Stefan Neufeind commented on patch set 2 05/05/14, 07:38
@Soren: Not sure. How do other FE-editing-functionalities handle that? The settings are not really generic and afaik are only used by feedit so far. I think it was the aloha-editing for which somebody mentioned they have their own (different) settings for example. Unfortunately this isn't really cleanly designed at the moment. Looking back it might have been better to allow a plugin to add any section to the admin-panel through a hook and provide that section as part of EXT:feedit - but we don't have that so far, and won't have it for 6.2.x I guess. -
Markus Klein updated the commit message in patch set 2 06/19/14, 20:49
-
Markus Klein uploaded patch set 4 06/19/14, 20:55
-
Markus Klein voted on patch set 4 V +1 CR +1 06/19/14, 20:55
-
Mr. Jenkins commented on patch set 3 06/19/14, 21:04
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16847/ : SUCCESS -
Stefan Neufeind commented on patch set 4 CR +1 06/19/14, 21:10
looked at it again myself, since Markus did quite some adjustments -
Mr. Jenkins commented on patch set 4 06/19/14, 21:15
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16848/ : SUCCESS -
Stefan Neufeind commented on patch set 4 06/28/14, 18:30
ping? -
Nicole Hummel commented on patch set 4 CR -1 06/28/14, 20:22
I wouldn't backport this patch to 6.2 and 6.1 as it isn't a real bugfix and was that way for ever. Maybe we should now take the time to rewrite the admin panel?! -
Stefan Neufeind updated the commit message in patch set 5 09/20/14, 18:21
-
Stefan Neufeind commented on patch set 5 09/20/14, 18:22
Vote from Markus imho still stands. Okay Nicole, removed 6.2/6.1 now from commit-msg. But (until we have a different solution) maybe let's have this for 6.3/master? -
Frans Saris commented on patch set 5 09/21/14, 08:40
As it is only for master now we should have a look at refactoring the admin panel like proposed in the comments. -
Stefan Neufeind commented on patch set 5 09/21/14, 16:03
Well, then jump at it please :-) I'd bet we have enough other things on our list and won't find the time. So maybe why not have this for now and see if we find time to refactor (and discuss and merge and ...) something in this direction later? -
Tymoteusz Motylewski commented on patch set 5 09/25/14, 17:32
The idea is good, but the patch hides too much. E.g. there are icons to edit the page properties or add new content elements which work without feedit installed. And they are gone after this patch. -
Markus Klein commented on patch set 5 12/01/14, 10:42
Stefan, please rework this patch! -
Markus Klein commented on patch set 5 CR -1 02/01/15, 23:22
Ping -
Alexander Opitz commented on patch set 5 06/24/15, 15:14
Hi Stefan, what is the state of this patch? -
Stefan Neufeind uploaded patch set 6 08/24/15, 00:05
-
Philipp Gampe voted on patch set 6 CR +1 08/24/15, 12:19
-
Georg Ringer uploaded patch set 7 11/14/15, 20:45
-
Georg Ringer voted on patch set 7 CR +1 V +1 11/14/15, 20:45
-
Oliver Eglseder voted on patch set 7 CR +1 11/14/15, 21:09
-
Josef Glatz voted on patch set 7 CR +1 11/14/15, 23:35
-
Michael Oehlhof voted on patch set 7 CR +1 11/15/15, 00:22
-
Oliver Eglseder voted on patch set 7 V +1 11/15/15, 11:14
-
Josef Glatz voted on patch set 7 V +1 11/15/15, 11:17
-
Georg Ringer voted on patch set 7 CR +2 V +2 11/15/15, 11:36
-
Gerrit merged patch set 7 11/15/15, 11:36