Review main Merged

29192[TASK] Avoid sysLog calls in MailUtilityTest

Markus Klein CR +2 V +2 Easy +4 −1 updated 04/05/14, 20:21

Commit message

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Stefan Neufeind +1
    • Oliver Klee +1
    • Pascal Dürsteler +1
  • Verified V +2
    • Christian Kuhn +2
    • Stefan Neufeind +1

Issues 1

Files 1

Review log 6

  1. Mr. Jenkins commented on patch set 1 04/05/14, 17:23

  2. Stefan Neufeind commented on patch set 1 V +1 CR +1 04/05/14, 18:33

    substitute-part is right before the actual call to mail(). That mail-functionality itself contains not much - but imho this substitute is a valid solution.
  3. Oliver Klee voted on patch set 1 CR +1 04/05/14, 18:37

  4. Pascal Dürsteler voted on patch set 1 CR +1 04/05/14, 18:41

  5. Christian Kuhn voted on patch set 1 V +2 CR +2 04/05/14, 20:21

  6. Christian Kuhn merged patch set 2 04/05/14, 20:21