29239[BUGFIX] User settings do not obey setup.override
Commit message
Review
-
Code review CR +2
- Stefan Neufeind +2
- Renzo Bauen +1
-
Verified V +2
- Stefan Neufeind +2
- Renzo Bauen +1
Issues 1
Files 1
Review log 8
-
Mr. Jenkins commented on patch set 1 04/07/14, 13:08
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15909/ : SUCCESS -
Stefan Neufeind commented on patch set 1 04/07/14, 13:11
SetupModuleController.php:489Do we need to check !empty() instead maybe? Can that setting be set but to zero (do not disable)? -
Markus Klein commented on patch set 1 04/07/14, 13:37
SetupModuleController.php:489ReplyThat's exactly the point! You can override this with any value (0 / 1) So empty is wrong here again. -
Stefan Neufeind commented on patch set 1 04/07/14, 13:47
While it would be more consistent, wouldn't it make more sense to make a value of zero / empty *not* disable the thing but override whatever enable/disable was set before? -
Renzo Bauen commented on patch set 1 V +1 CR +1 04/07/14, 13:49
So i put this patch on my test setup. And it looks good. The checkboxes of the overriden settings are disabled, indipendent of the setting (0 or 1). For me, you did a good job! Thans a lot! Best Regards, Renzo -
Stefan Neufeind commented on patch set 1 V +2 CR +2 04/07/14, 13:55
The override-value will be used and it should not be possible for the user to change that again. Thanks Markus for the clarification. Of course this is fine then. -
Stefan Neufeind merged patch set 2 04/07/14, 13:55
-
Stefan Neufeind commented on patch set 2 04/07/14, 13:55
Cherry Picked This patchset was cherry picked to change: Id1290b2af85061051ce0cedff4a0be96a91c4dce