Review main Merged

29239[BUGFIX] User settings do not obey setup.override

Markus Klein CR +2 V +2 Easy +1 −1 updated 04/07/14, 13:55

Commit message

Add a missing isset() check whether a setting has been overridden
by user TSconfig.

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Renzo Bauen +1
  • Verified V +2
    • Stefan Neufeind +2
    • Renzo Bauen +1

Issues 1

Files 1

Review log 8

  1. Mr. Jenkins commented on patch set 1 04/07/14, 13:08

  2. Stefan Neufeind commented on patch set 1 04/07/14, 13:11

    SetupModuleController.php:489

    Do we need to check !empty() instead maybe? Can that setting be set but to zero (do not disable)?
  3. Markus Klein commented on patch set 1 04/07/14, 13:37

    SetupModuleController.php:489 Reply

    That's exactly the point! You can override this with any value (0 / 1) So empty is wrong here again.
  4. Stefan Neufeind commented on patch set 1 04/07/14, 13:47

    While it would be more consistent, wouldn't it make more sense to make a value of zero / empty *not* disable the thing but override whatever enable/disable was set before?
  5. Renzo Bauen commented on patch set 1 V +1 CR +1 04/07/14, 13:49

    So i put this patch on my test setup. And it looks good. The checkboxes of the overriden settings are disabled, indipendent of the setting (0 or 1). For me, you did a good job! Thans a lot! Best Regards, Renzo
  6. Stefan Neufeind commented on patch set 1 V +2 CR +2 04/07/14, 13:55

    The override-value will be used and it should not be possible for the user to change that again. Thanks Markus for the clarification. Of course this is fine then.
  7. Stefan Neufeind merged patch set 2 04/07/14, 13:55

  8. Stefan Neufeind commented on patch set 2 04/07/14, 13:55

    Cherry Picked This patchset was cherry picked to change: Id1290b2af85061051ce0cedff4a0be96a91c4dce