Review main Merged

2925[BUGFIX] Gap between module menu items causes collapse on click

Kay Strobach CR +2 V +2 Easy +4 −1 updated 06/03/13, 20:49

Commit message

Transform the margins between entries in the module menu into paddings
to avoid that clicks on this margin cause collapsing of the menu
section.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Susi Moog +2
    • Andreas Wolf +2
    • Stefan Neufeind +1
    • Kay Strobach +1
    • Steffen Gebert +1
    • Philipp Gampe +1
  • Verified V +2
    • Andreas Wolf +2
    • Stefan Neufeind +1
    • Georg Ringer +1
    • Kay Strobach +1
    • Steffen Gebert +1
    • Philipp Gampe +1

Issues 1

Files 1

Review log 17

  1. Steffen Gebert commented on patch set 1 07/12/11, 15:52

    I would prefer that you didn't submit this Yes, Jenkins is somehow comparing against another build. That's kind of a known problem that this happens. Please fix the mentioned details.
    English please :D
    please read carefully! "auf" ;-)
    Sorry, that must not be part of a commit message

    module_menu.css:22

    please add a space in between

    module_menu.css:28

    here also spaces, please
  2. Kay Strobach commented on patch set 1 07/12/11, 15:52

    can't understand mr jenkins ... my file isn't in the list of false files :(
  3. Steffen Gebert commented on patch set 2 2 comments 07/12/11, 15:52

    I would prefer that you didn't submit this
  4. Andreas Wolf commented on patch set 3 V 0 07/12/11, 15:52

    by team member; Looks good to me, approved
  5. Stefan Neufeind commented on patch set 3 07/12/11, 15:52

    Verified; Looks good to me, but someone else must approve
  6. Susi Moog commented on patch set 3 07/12/11, 15:52

    Looks good to me, approved
  7. Georg Ringer commented on patch set 3 07/12/11, 15:52

    Looks good to me, approved
  8. Georg Ringer commented on patch set 3 07/12/11, 15:52

    Verified; Looks good to me, but someone else must approve
  9. Steffen Gebert uploaded patch set 3 07/12/11, 15:52

  10. Steffen Gebert commented on patch set 3 07/12/11, 15:52

    Verified; Looks good to me, but someone else must approve
  11. Kay Strobach uploaded patch set 2 07/12/11, 15:52

  12. Kay Strobach commented on patch set 3 07/12/11, 15:52

    Verified; Looks good to me, but someone else must approve ahh, still learning git - sry - but thanks for support.
  13. Philipp Gampe commented on patch set 3 07/12/11, 15:52

    Verified; Looks good to me, but someone else must approve
  14. Mr. Jenkins commented on patch set 1 07/12/11, 15:52

    Fails; I would prefer that you didn't submit this Build Failed http://ci.typo3.org/job/typo3-v4-core-gerrit/812/ : FAILURE
  15. Mr. Jenkins commented on patch set 2 07/12/11, 15:52

    Fails; I would prefer that you didn't submit this Build Failed http://ci.typo3.org/job/typo3-v4-core-gerrit/813/ : FAILURE
  16. Mr. Jenkins commented on patch set 3 07/12/11, 15:52

  17. Andreas Wolf merged patch set 3 07/12/11, 15:52