Review main Merged

29335[BUGFIX] Properly detect HHVM with fastcgi

Kevin Häfeli CR +2 V +2 Normal +51 −10 updated 04/12/14, 19:35

Commit message

Extend the PHP_SAPI check with "srv" to match the interface between
the webserver and PHP also for Facebook's HHVM and set the paths
correctly for HHVM hostings.

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Christian Kuhn +1
  • Verified V +2
    • Stefan Neufeind +2
    • Christian Kuhn +1

Issues 1

Files 3

Review log 18

  1. Markus Klein commented on patch set 1 04/10/14, 11:52

    Thanks for you patch!! Looking at this I wonder why we need this to be spread over 3 places. I propose to introduce a new function in lets say GeneralUtility to centralize this check. What do you think?
  2. Mr. Jenkins commented on patch set 1 04/10/14, 12:01

  3. Markus Klein uploaded patch set 2 04/10/14, 12:22

  4. Mr. Jenkins commented on patch set 2 04/10/14, 12:35

  5. Wouter Wolters commented on patch set 2 04/10/14, 12:44

    SystemEnvironmentBuilder.php:509

    3rd param TRUE ?
  6. Markus Klein uploaded patch set 3 04/10/14, 13:44

  7. Mr. Jenkins commented on patch set 3 04/10/14, 13:58

  8. Christian Kuhn commented on patch set 3 CR -1 04/10/14, 16:09

    SystemEnvironmentBuilder.php:508

    Mmmh, SystemEnvironment*Builder* should not have multiple public methods, run() should stay as single entry points. Please do not mix this. If this code is still needed at other points (eg. GeneralUtility), I'd suggest to copy the code over there, too. Lets keep this class here "closed", it is designed to be called exactly once from other bootstrap classes and should not fit other purposes.
  9. Markus Klein uploaded patch set 4 04/10/14, 16:23

  10. Christian Kuhn commented on patch set 4 04/10/14, 16:25

    nice. will have a detailed look this evening.
  11. Markus Klein uploaded patch set 5 04/10/14, 16:27

  12. Markus Klein uploaded patch set 6 04/10/14, 16:28

  13. Mr. Jenkins commented on patch set 4 04/10/14, 16:37

  14. Mr. Jenkins commented on patch set 5 04/10/14, 16:42

  15. Mr. Jenkins commented on patch set 6 04/10/14, 16:51

  16. Christian Kuhn voted on patch set 6 V +1 CR +1 04/12/14, 15:49

  17. Stefan Neufeind commented on patch set 6 V +2 CR +2 04/12/14, 19:35

    Don't have hhvm to test this out with. But I trust you on that part :-)
  18. Stefan Neufeind merged patch set 7 04/12/14, 19:35