Review main Merged

29355[CLEANUP] Improve comments in TypoScriptFrontendController

mostwanted CR +2 V +2 Hard +484 −243 updated 05/21/14, 11:47

Commit message

Review

  • Code review CR +2
    • Helmut Hummel +2
    • Oliver Klee +1
    • Christian Kuhn +1
  • Verified V +2
    • Helmut Hummel +2
    • Christian Kuhn +1

Issues 1

Files 4

Review log 18

  1. mostwanted uploaded patch set 2 04/10/14, 16:40

  2. Mr. Jenkins commented on patch set 1 04/10/14, 16:56

  3. Mr. Jenkins commented on patch set 2 04/10/14, 17:04

  4. Markus Klein uploaded patch set 3 04/11/14, 00:32

  5. Markus Klein voted on patch set 3 V +1 CR +1 04/11/14, 00:35

  6. Mr. Jenkins commented on patch set 3 04/11/14, 00:46

  7. Christian Kuhn uploaded patch set 4 04/12/14, 14:24

  8. Christian Kuhn voted on patch set 4 V +1 CR +1 04/12/14, 14:30

  9. Oliver Klee voted on patch set 4 CR +1 04/12/14, 14:32

  10. Mr. Jenkins commented on patch set 4 04/12/14, 14:38

  11. Markus Klein commented on patch set 4 04/12/14, 15:42

    update coming along

    TypoScriptFrontendController.php:2344

    a simple (bool) cast void be even nicer!
  12. Markus Klein uploaded patch set 5 04/12/14, 15:52

  13. Christian Kuhn commented on patch set 5 V +1 CR +1 04/12/14, 16:04

    +1 get it done ...
  14. Mr. Jenkins commented on patch set 5 04/12/14, 16:05

  15. Oliver Klee voted on patch set 5 CR +1 04/12/14, 17:12

  16. Helmut Hummel voted on patch set 5 V +2 CR +2 04/12/14, 17:57

  17. Helmut Hummel merged patch set 6 04/12/14, 17:57

  18. Markus Klein commented on patch set 6 05/21/14, 11:47

    Causes a regression with FE preview: https://review.typo3.org/30212