29432[CLEANUP] Rename $TT to $timeTracker in index_ts.php
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 2
Review log 5
-
Oliver Klee voted on patch set 1 CR +1 04/12/14, 17:07
-
Christian Kuhn commented on patch set 1 04/12/14, 17:09
Warning: This needs an impact assessment: Since index_ts is code in global scope, $TT is also defined globally (we did not manage yet to move this global code to class scope), so $TT is accessible via $GLOBALS['TT'] everywhere. Just renaming this is potentially breaking and we should be sure about what we are doing here. -
Mr. Jenkins commented on patch set 1 04/12/14, 17:14
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15972/ : SUCCESS -
mostwanted commented on patch set 1 04/12/14, 17:20
Uups. sorry. After some quick search i found out that e.g. EXT:realurl uses $GLOBALS['TT']. I guess i should abandon this patch. do you agree? -
mostwanted abandoned the change 04/12/14, 19:08