Review main Abandoned

29432[CLEANUP] Rename $TT to $timeTracker in index_ts.php

mostwanted CR 0 V 0 Easy +21 −21 updated 04/12/14, 19:08

Commit message

Rename $TT to $timeTracker in index_ts.php to improve
readability of code.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 5

  1. Oliver Klee voted on patch set 1 CR +1 04/12/14, 17:07

  2. Christian Kuhn commented on patch set 1 04/12/14, 17:09

    Warning: This needs an impact assessment: Since index_ts is code in global scope, $TT is also defined globally (we did not manage yet to move this global code to class scope), so $TT is accessible via $GLOBALS['TT'] everywhere. Just renaming this is potentially breaking and we should be sure about what we are doing here.
  3. Mr. Jenkins commented on patch set 1 04/12/14, 17:14

  4. mostwanted commented on patch set 1 04/12/14, 17:20

    Uups. sorry. After some quick search i found out that e.g. EXT:realurl uses $GLOBALS['TT']. I guess i should abandon this patch. do you agree?
  5. mostwanted abandoned the change 04/12/14, 19:08