Review main Merged

29439[CLEANUP] Clean up comments and error messages in ResourceStorage

Oliver Klee CR +2 V +2 Hard +161 −132 updated 04/15/14, 01:36

Commit message

This changes adds some missing @throws annotations and improves the
readability of some comments.

Also fix a typo in an exception and reformat some exceptions for
better readability.

Moreover add some checks if the correct type is present
before calling undefined methods.

This change does not introduce any functional changes.

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Markus Klein +1
  • Verified V +2
    • Stefan Neufeind +2
    • Markus Klein +1

Issues 1

Files 1

Review log 14

  1. Mr. Jenkins commented on patch set 1 04/13/14, 11:09

  2. Oliver Klee updated the commit message in patch set 1 04/13/14, 12:33

  3. Mr. Jenkins commented on patch set 2 04/13/14, 12:46

  4. Alexander Opitz commented on patch set 2 04/14/14, 06:53

    ResourceStorage.php:407

    Where does this 5 Minutes come from? Isn't this configurable? "Marks this storage as temporarily offline."
  5. Oliver Klee commented on patch set 2 04/14/14, 09:08

    ResourceStorage.php:407 Reply

    The 5 minutes come from former line 401 (and is hardcoded in line 407). I've just consolidated the sentences.
  6. Alexander Opitz commented on patch set 2 V +1 CR +1 04/14/14, 12:14

    No issues with FAL, while clicking around.

    ResourceStorage.php:407 Reply

    Ohh I missed the 5 inside the function. :-( Not cool, but ok.
  7. Markus Klein commented on patch set 2 04/15/14, 01:04

    change-id within the last paragraph please.
  8. Markus Klein uploaded patch set 3 04/15/14, 01:14

  9. Markus Klein uploaded patch set 4 04/15/14, 01:20

  10. Markus Klein voted on patch set 4 V +1 CR +1 04/15/14, 01:22

  11. Mr. Jenkins commented on patch set 3 04/15/14, 01:30

  12. Stefan Neufeind voted on patch set 4 V +2 CR +2 04/15/14, 01:33

  13. Stefan Neufeind merged patch set 5 04/15/14, 01:34

  14. Mr. Jenkins commented on patch set 4 04/15/14, 01:36