29439[CLEANUP] Clean up comments and error messages in ResourceStorage
Commit message
Review
-
Code review CR +2
- Stefan Neufeind +2
- Markus Klein +1
-
Verified V +2
- Stefan Neufeind +2
- Markus Klein +1
Issues 1
Files 1
Review log 14
-
Mr. Jenkins commented on patch set 1 04/13/14, 11:09
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15983/ : SUCCESS -
Oliver Klee updated the commit message in patch set 1 04/13/14, 12:33
-
Mr. Jenkins commented on patch set 2 04/13/14, 12:46
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15985/ : SUCCESS -
Alexander Opitz commented on patch set 2 04/14/14, 06:53
ResourceStorage.php:407Where does this 5 Minutes come from? Isn't this configurable? "Marks this storage as temporarily offline." -
Oliver Klee commented on patch set 2 04/14/14, 09:08
ResourceStorage.php:407ReplyThe 5 minutes come from former line 401 (and is hardcoded in line 407). I've just consolidated the sentences. -
Alexander Opitz commented on patch set 2 V +1 CR +1 04/14/14, 12:14
No issues with FAL, while clicking around.ResourceStorage.php:407ReplyOhh I missed the 5 inside the function. :-( Not cool, but ok. -
Markus Klein commented on patch set 2 04/15/14, 01:04
change-id within the last paragraph please. -
Markus Klein uploaded patch set 3 04/15/14, 01:14
-
Markus Klein uploaded patch set 4 04/15/14, 01:20
-
Markus Klein voted on patch set 4 V +1 CR +1 04/15/14, 01:22
-
Mr. Jenkins commented on patch set 3 04/15/14, 01:30
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16012/ : SUCCESS -
Stefan Neufeind voted on patch set 4 V +2 CR +2 04/15/14, 01:33
-
Stefan Neufeind merged patch set 5 04/15/14, 01:34
-
Mr. Jenkins commented on patch set 4 04/15/14, 01:36
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16013/ : SUCCESS